Issue 371523002: Fix SkColorFilterImageFilter matrix optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371523002: Fix SkColorFilterImageFilter matrix optimization. (Closed)

Created:
6 years, 5 months ago by Stephen White

Modified:
6 years, 5 months ago

Reviewers:
sugoi1, sugoi

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fix SkColorFilterImageFilter matrix optimization. The order of matrices passed to multiplication was wrong (apparently, this optimization was only being tested with matrices which commute). See Chrome bug http://crbug.com/378362 R=sugoi@chromium.org Committed: https://skia.googlesource.com/skia/+/3df05015efce95c306fb79c21efc77c79f1ac1ba

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	src/effects/SkColorFilterImageFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/ImageFilterTest.cpp	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

sugoi

On 2014/07/03 17:26:03, Stephen White wrote: > sugoi@: PTAL. adTHANKSvance! LGTM

6 years, 5 months ago (2014-07-03 17:34:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/371523002/1

6 years, 5 months ago (2014-07-03 17:48:23 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-03 18:13:12 UTC) #5

Message was sent while issue was closed.

Change committed as 3df05015efce95c306fb79c21efc77c79f1ac1ba