Source/core/html/HTMLInputElement.cpp - Issue 371413004: Fix for input/datalist failure when datalist is created outside document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 371413004: Fix for input/datalist failure when datalist is created outside document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/datalist/datalist-inside-shadow-dom-expected.html ('K') | « LayoutTests/fast/forms/datalist/datalist-inside-shadow-dom-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 51c4fd0ef83fef4602c59a246282e813829fc202..560e92d42f6b2f25293f5a96b4098f8782438ac4 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -727,7 +727,6 @@ void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr

m_hasNonEmptyList = !value.isEmpty();

if (m_hasNonEmptyList) {

resetListAttributeTargetObserver();

- listAttributeTargetChanged();

}

UseCounter::count(document(), UseCounter::ListAttribute);

} else if (name == webkitdirectoryAttr) {

@@ -1540,6 +1539,7 @@ void HTMLInputElement::setListAttributeTargetObserver(PassOwnPtrWillBeRawPtr<Lis

void HTMLInputElement::resetListAttributeTargetObserver()

{

+ listAttributeTargetChanged();

if (inDocument())

setListAttributeTargetObserver(ListAttributeTargetObserver::create(fastGetAttribute(listAttr), this));

else