Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 371413003: NaCl: Update revision in DEPS, r13441 -> r13452 (Closed)

Created:
6 years, 5 months ago by Mark Seaborn
Modified:
6 years, 5 months ago
CC:
chromium-reviews, David Yen, hamaji, native-client-reviews_googlegroups.com, Nick Bray (chromium), noelallen_use_chromium, Nico
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13441 -> r13452 This pulls in the following Native Client changes: r13442: (dyen) Added support for log uploading for commands in toolchain_build. r13443: (noelallen) Rolls DEPS file to get deps aware toolchains. r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes. r13446: (ncbray) Factor arg parsing in sel_ldr into its own function. r13447: (ncbray) Add my chromium account to OWNERS with my google account. r13448: (dyen) Fixed repo_tools invalid reference to pynacl. r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck. r13450: (ncbray) Consolidate sel_ldr's configuration logic. r13451: (dyen) Package Version script now supports downloading build logs. r13452: (hamaji) Non-SFI Mode: Add isatty interface BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
6 years, 5 months ago (2014-07-08 16:29:00 UTC) #1
Nick Bray (chromium)
LGTM
6 years, 5 months ago (2014-07-08 16:50:37 UTC) #2
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 5 months ago (2014-07-08 16:56:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/371413003/1
6 years, 5 months ago (2014-07-08 16:58:18 UTC) #4
commit-bot: I haz the power
Change committed as 281849
6 years, 5 months ago (2014-07-08 22:42:23 UTC) #5
samuong
6 years, 5 months ago (2014-07-09 00:34:33 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/379663002/ by samuong@chromium.org.

The reason for reverting is: Suspect this is causing PPAPINaClNewlibTest.FileIO
to crash on Mac:

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%28....

Powered by Google App Engine
This is Rietveld 408576698