Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 371403002: Oilpan: have SharedWorker trace its message port. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, arv+blink, Inactive, falken
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: have SharedWorker trace its message port. Also remove the unused AbstractWorker::asID() helper. R=haraken@chromium.org,ager@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/workers/AbstractWorker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/workers/SharedWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-08 13:01:23 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-08 13:07:31 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 5 months ago (2014-07-08 13:07:38 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-08 13:10:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/371403002/1
6 years, 5 months ago (2014-07-08 13:11:18 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 14:13:00 UTC) #6
Message was sent while issue was closed.
Change committed as 177673

Powered by Google App Engine
This is Rietveld 408576698