Issue 371393002: Removes unnecessary call of TextInputFocusManager in ui/wm/test/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371393002: Removes unnecessary call of TextInputFocusManager in ui/wm/test/ (Closed)

Created:
6 years, 5 months ago by Yuki

Modified:
6 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sky, msw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Removes unnecessary call of TextInputFocusManager in ui/wm/test/ http://crrev.com/340413002 introduced two calls of ui::TextInputFocusManager::FocusTextInputClient in wm::WMTestHelper because I thought it was necessary. But it turned out that they're not necessary after the fix of http://crrev.com/347103002 . Thus removes these calls. BUG=290701 TEST=Run content_browsertests and browser_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282576

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -5 lines)			Patch
M	ui/wm/test/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/wm/test/wm_test_helper.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	ui/wm/wm.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Yuki

Could you review this CL? I should send this CL to sky@, but he is ...

6 years, 5 months ago (2014-07-09 05:16:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/371393002/1

6 years, 5 months ago (2014-07-11 04:25:35 UTC) #4

Message was sent while issue was closed.

Change committed as 282576