Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 371363008: Disable DownloadExtensionTest_Download_InvalidURLs on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
index a08acf422c98078a3832c586dd4630946622e950..2cbefc67b4a054166465166cf3ae52b3a1a0e6bb 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
@@ -1680,9 +1680,18 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,
download_url.c_str())).c_str());
}
+// flaky on mac: crbug.com/392288
+#if defined(OS_MACOSX)
+#define MAYBE_DownloadExtensionTest_Download_InvalidURLs \
+ DISABLED_DownloadExtensionTest_Download_InvalidURLs
+#else
+#define MAYBE_DownloadExtensionTest_Download_InvalidURLs \
+ DownloadExtensionTest_Download_InvalidURLs
+#endif
+
// Test that downloading invalid URLs immediately returns kInvalidURLError.
IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,
- DownloadExtensionTest_Download_InvalidURLs) {
+ MAYBE_DownloadExtensionTest_Download_InvalidURLs) {
LoadExtension("downloads_split");
GoOnTheRecord();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698