Issue 371363005: [DevTools] Add explicit closing state in DevToolsWindow life time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371363005: [DevTools] Add explicit closing state in DevToolsWindow life time. (Closed)

Created:
6 years, 5 months ago by dgozman

Modified:
6 years, 5 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Add explicit closing state in DevToolsWindow life time. Previously, DevToolsWindow relied on DevToolsClientHost life time, which is error prone and introduced quite a few bugs. BUG=392180 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282000

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -37 lines)			Patch
	M	chrome/browser/devtools/devtools_window.h	View		3 chunks	+10 lines, -5 lines	0 comments	Download
	M	chrome/browser/devtools/devtools_window.cc	View		12 chunks	+28 lines, -32 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/371363005/1

6 years, 5 months ago (2014-07-09 07:42:51 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...

6 years, 5 months ago (2014-07-09 09:40:10 UTC) #5

Message was sent while issue was closed.

Change committed as 282000

Expand Messages | Collapse Messages