Issue 371363003: Add predictable mode to test driver.

Issue 371363003: Add predictable mode to test driver. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach

Modified:
6 years, 5 months ago

Reviewers:
Igor Sheludko, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add predictable mode to test driver. BUG=391747 LOG=n R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22285

Patch Set 2 : Extra flag. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -19 lines)			Patch
M	tools/run-deopt-fuzzer.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/run-tests.py	View	1	4 chunks	+15 lines, -1 line	0 comments	Download
M	tools/testrunner/local/execution.py	View		2 chunks	+61 lines, -14 lines	0 comments	Download
M	tools/testrunner/objects/context.py	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	tools/testrunner/objects/output.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

PTAL https://codereview.chromium.org/371363003/diff/20001/tools/testrunner/local/execution.py File tools/testrunner/local/execution.py (right): https://codereview.chromium.org/371363003/diff/20001/tools/testrunner/local/execution.py#newcode129 tools/testrunner/local/execution.py:129: def _ProcessTestNormal(self, test, result, pool): This is basically ...

6 years, 5 months ago (2014-07-08 13:04:19 UTC) #1

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/371363003/diff/20001/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/371363003/diff/20001/tools/run-tests.py#newcode310 tools/run-tests.py:310: options.extra_flags.append("--verify_predictable") Add --no-inline-new to make ...

6 years, 5 months ago (2014-07-08 13:15:20 UTC) #2

Michael Achenbach

On 2014/07/08 13:15:20, Igor Sheludko wrote: > lgtm with a nit: > > https://codereview.chromium.org/371363003/diff/20001/tools/run-tests.py > ...

6 years, 5 months ago (2014-07-08 14:07:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22285.

Expand Messages | Collapse Messages