Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 371353005: Remove deprecated OmniboxSuggestion constructor. (Closed)

Created:
6 years, 5 months ago by Justin Donnelly
Modified:
6 years, 5 months ago
Reviewers:
Ted C, Yaron, Maria
CC:
chromium-reviews, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated OmniboxSuggestion constructor. BUG=375482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282049

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Justin Donnelly
6 years, 5 months ago (2014-07-08 20:02:44 UTC) #1
Maria
lgtm
6 years, 5 months ago (2014-07-08 20:04:34 UTC) #2
Justin Donnelly
Thanks, Maria. Ted, can I get an owners approval when you get a chance?
6 years, 5 months ago (2014-07-08 20:18:13 UTC) #3
chromium-reviews
+Yaron Ted is out for a couple of weeks. Yaron, can you approve? On Jul ...
6 years, 5 months ago (2014-07-08 20:28:42 UTC) #4
Yaron
lgtm
6 years, 5 months ago (2014-07-08 20:41:25 UTC) #5
Justin Donnelly
The CQ bit was checked by jdonnelly@chromium.org
6 years, 5 months ago (2014-07-09 13:52:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/371353005/20001
6 years, 5 months ago (2014-07-09 13:53:31 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 15:57:07 UTC) #8
Message was sent while issue was closed. 
Change committed as 282049

Powered by Google App Engine
This is Rietveld 408576698