Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 371333003: No content dependencies in TemplateURLFetcher (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

No content dependencies in TemplateURLFetcher BUG=371535 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281973

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -46 lines) Patch
M chrome/browser/search_engines/template_url_fetcher.h View 1 4 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 9 chunks +21 lines, -31 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
6 years, 5 months ago (2014-07-08 10:25:05 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/371333003/diff/20001/chrome/browser/search_engines/template_url_fetcher.h File chrome/browser/search_engines/template_url_fetcher.h (right): https://codereview.chromium.org/371333003/diff/20001/chrome/browser/search_engines/template_url_fetcher.h#newcode57 chrome/browser/search_engines/template_url_fetcher.h:57: // parameters to the URLFetcher. Nit: to -> ...
6 years, 5 months ago (2014-07-09 01:00:51 UTC) #2
hashimoto
https://codereview.chromium.org/371333003/diff/20001/chrome/browser/search_engines/template_url_fetcher.h File chrome/browser/search_engines/template_url_fetcher.h (right): https://codereview.chromium.org/371333003/diff/20001/chrome/browser/search_engines/template_url_fetcher.h#newcode57 chrome/browser/search_engines/template_url_fetcher.h:57: // parameters to the URLFetcher. On 2014/07/09 01:00:51, Peter ...
6 years, 5 months ago (2014-07-09 02:52:26 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-09 02:52:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/371333003/40001
6 years, 5 months ago (2014-07-09 02:55:18 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 06:11:24 UTC) #6
Message was sent while issue was closed. 
Change committed as 281973

Powered by Google App Engine
This is Rietveld 408576698