Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 371333002: Gallery.app: Update the ribbon control when the item is inserted. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Update the ribbon control when the item is inserted. The CL also fixes the insertion position of the new item, so that the new item is inserted behind of the existing selected item. Previously the image item is inserted ahead of the selected item. It changes the index of the selected item, and it causes the inconsistency between the selected index and the selected item. BUG=392055 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282044

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 2 chunks +13 lines, -9 lines 0 comments Download
M ui/file_manager/gallery/js/ribbon.js View 1 3 chunks +24 lines, -7 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-08 10:04:41 UTC) #1
yoshiki
lgtm
6 years, 5 months ago (2014-07-08 10:06:41 UTC) #2
hirono
On 2014/07/08 10:06:41, yoshiki wrote: > lgtm I realized that calling redraw() method is not ...
6 years, 5 months ago (2014-07-09 03:36:17 UTC) #3
yoshiki
https://codereview.chromium.org/371333002/diff/60001/ui/file_manager/gallery/js/ribbon.js File ui/file_manager/gallery/js/ribbon.js (right): https://codereview.chromium.org/371333002/diff/60001/ui/file_manager/gallery/js/ribbon.js#newcode118 ui/file_manager/gallery/js/ribbon.js:118: this.insertBefore(element, nextElement); if nextElement is null, it may fail.
6 years, 5 months ago (2014-07-09 03:49:01 UTC) #4
hirono
https://codereview.chromium.org/371333002/diff/60001/ui/file_manager/gallery/js/ribbon.js File ui/file_manager/gallery/js/ribbon.js (right): https://codereview.chromium.org/371333002/diff/60001/ui/file_manager/gallery/js/ribbon.js#newcode118 ui/file_manager/gallery/js/ribbon.js:118: this.insertBefore(element, nextElement); On 2014/07/09 03:49:01, yoshiki wrote: > if ...
6 years, 5 months ago (2014-07-09 04:04:54 UTC) #5
yoshiki
I didn't know that. Then LGTM
6 years, 5 months ago (2014-07-09 07:32:14 UTC) #6
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-09 09:11:13 UTC) #7
hirono
On 2014/07/09 07:32:14, yoshiki wrote: > I didn't know that. Then LGTM Thanks!
6 years, 5 months ago (2014-07-09 09:11:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/371333002/60001
6 years, 5 months ago (2014-07-09 09:11:45 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 15:46:17 UTC) #10
Message was sent while issue was closed.
Change committed as 282044

Powered by Google App Engine
This is Rietveld 408576698