Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 371293006: Remove calls to idleNotification (Closed)

Created:
6 years, 5 months ago by Will Harris
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Test to remove calls to tab idleNotification, to try and diagnose a bug. This will be removed after a Canary run. BUG=381820 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/public/renderer/content_renderer_client.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Will Harris
6 years, 5 months ago (2014-07-08 19:15:50 UTC) #1
Will Harris
I removed both calls, if we were more conservative I could remove just the MemoryPressure ...
6 years, 5 months ago (2014-07-08 19:16:27 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-08 19:24:06 UTC) #3
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 5 months ago (2014-07-08 19:38:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/371293006/1
6 years, 5 months ago (2014-07-08 19:40:20 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 23:56:46 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 00:23:36 UTC) #7
Message was sent while issue was closed.
Change committed as 281901

Powered by Google App Engine
This is Rietveld 408576698