Issue 371283002: Componentize HistoryMatch

Issue 371283002: Componentize HistoryMatch (Closed)

Created:
6 years, 5 months ago by hashimoto

Modified:
6 years, 5 months ago

Reviewers:
Peter Kasting, blundell

CC:
chromium-reviews, James Su, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Componentize HistoryMatch HistoryMatch is placed under the history namespace and has no dependency to autocomplete. It should be placed under components/history. BUG=388515 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281971

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -108 lines)			Patch
D	chrome/browser/autocomplete/history_provider_util.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download
D	chrome/browser/autocomplete/history_provider_util.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/scored_history_match.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/history.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	components/history/core/browser/history_match.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
A +	components/history/core/browser/history_match.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

hashimoto

Colin, please review this change as an owner of history. Peter, please review this change ...

6 years, 5 months ago (2014-07-08 08:02:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/371283002/1

6 years, 5 months ago (2014-07-09 01:59:53 UTC) #5

Message was sent while issue was closed.

Change committed as 281971