add setPreserveSrcDepth to replace PrefTable API for android

add setPreserveSrcDepth to replace PrefTable API for android

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/be08aceaab724b21136d7654fa86315850e9993c

[reed1, 2014-07-08 17:17:23]

the only caller I see is one in android, where their preftable returns exactly
what the new API hard-codes.

[scroggo, 2014-07-08 17:31:07]

https://codereview.chromium.org/371273007/diff/1/include/core/SkImageDecoder.h
File include/core/SkImageDecoder.h (right):

https://codereview.chromium.org/371273007/diff/1/include/core/SkImageDecoder....
include/core/SkImageDecoder.h:211: *  from a peeker to change that, causing the
codec to try to match the
The only caller is from a Peeker (I suppose so that it only happens for PNG
images with nine patch), but I don't think that's a part of the API. Someone
could choose to call this without creating an extra class.

https://codereview.chromium.org/371273007/diff/1/include/core/SkImageDecoder....
include/core/SkImageDecoder.h:213: *  setPrefConfigTable().
Do we really need this reference to a deprecated (and presumably soon to be
removed) function?

https://codereview.chromium.org/371273007/diff/1/src/images/SkImageDecoder.cpp
File src/images/SkImageDecoder.cpp (right):

https://codereview.chromium.org/371273007/diff/1/src/images/SkImageDecoder.cp...
src/images/SkImageDecoder.cpp:43: void
SkImageDecoder::copyFieldsToOther(SkImageDecoder* other) {
I think we should copy fPreserveSrcDepth here as well.

[reed1, 2014-07-08 17:41:25]

https://codereview.chromium.org/371273007/diff/1/include/core/SkImageDecoder.h
File include/core/SkImageDecoder.h (right):

https://codereview.chromium.org/371273007/diff/1/include/core/SkImageDecoder....
include/core/SkImageDecoder.h:211: *  from a peeker to change that, causing the
codec to try to match the
On 2014/07/08 17:31:07, scroggo wrote:
> The only caller is from a Peeker (I suppose so that it only happens for <span
id="abbrex-spnAbbr_26124" class="abbrex-Abbr abbrex-Abbr_PNG abbrex-AbbrUnknown
abbrex-AbbrUnknownVisible">PNG</span>
> images with nine patch), but I don't think that's a part of the <span
id="abbrex-spnAbbr_26125" class="abbrex-Abbr abbrex-Abbr_API abbrex-AbbrUnknown
abbrex-AbbrUnknownVisible">API</span>. Someone
> could choose to call this without creating an extra class.

Done.

https://codereview.chromium.org/371273007/diff/1/include/core/SkImageDecoder....
include/core/SkImageDecoder.h:213: *  setPrefConfigTable().
On 2014/07/08 17:31:07, scroggo wrote:
> Do we really need this reference to a deprecated (and presumably soon to be
> removed) function?

Done.

https://codereview.chromium.org/371273007/diff/1/src/images/SkImageDecoder.cpp
File src/images/SkImageDecoder.cpp (right):

https://codereview.chromium.org/371273007/diff/1/src/images/SkImageDecoder.cp...
src/images/SkImageDecoder.cpp:43: void
SkImageDecoder::copyFieldsToOther(SkImageDecoder* other) {
On 2014/07/08 17:31:07, scroggo wrote:
> I think we should copy fPreserveSrcDepth here as well.

Done.

[scroggo, 2014-07-08 17:46:02]

lgtm

https://codereview.chromium.org/371273007/diff/20001/include/core/SkImageDeco...
File include/core/SkImageDecoder.h (right):

https://codereview.chromium.org/371273007/diff/20001/include/core/SkImageDeco...
include/core/SkImageDecoder.h:211: *  to change that, causing the codec to try
to match the src depth instead
nit: maybe this should be "override" instead of "change". Some src depths will
still result in using the pref colortype.

[reed1, 2014-07-08 17:48:48]

https://codereview.chromium.org/371273007/diff/20001/include/core/SkImageDeco...
File include/core/SkImageDecoder.h (right):

https://codereview.chromium.org/371273007/diff/20001/include/core/SkImageDeco...
include/core/SkImageDecoder.h:211: *  to change that, causing the codec to try
to match the src depth instead
On 2014/07/08 17:46:02, scroggo wrote:
> nit: maybe this should be "override" instead of "change". Some src depths will
> still result in using the pref colortype.

Done.

[reed1, 2014-07-08 17:49:13]

requesting cherry-pick into android :)

[reed1, 2014-07-08 17:49:16]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-07-08 17:49:27]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/371273007/40001

[scroggo, 2014-07-08 18:01:05]

On 2014/07/08 17:49:13, reed1 wrote:
> requesting cherry-pick into android :)

I don't see any harm in cherry-picking. Alternatively, we could make the
corresponding changes in frameworks/base in the master-skia branch. Either way
is fine with me.

[commit-bot: I haz the power, 2014-07-08 18:16:04]

Change committed as be08aceaab724b21136d7654fa86315850e9993c