Issue 371273006: Back off from SkPicture API hardening a bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371273006: Back off from SkPicture API hardening a bit (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Back off from SkPicture API hardening a bit Sigh - Chromium still relies on the old clone functionality TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/004522f

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	include/core/SkPicture.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-08 16:18:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/371273006/20001

6 years, 5 months ago (2014-07-08 16:19:08 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 5 months ago (2014-07-08 16:19:13 UTC) #4

commit-bot: I haz the power

Presubmit check for 371273006-20001 failed and returned exit status 1. Running presubmit commit checks ...

6 years, 5 months ago (2014-07-08 16:19:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r004522f.