chrome/browser/content_settings/permission_context_base.cc - Issue 371263003: Add tests for the permission context class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_context_base.cc

Issue 371263003: Add tests for the permission context class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bernhard's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/content_settings/permission_context_base.cc

diff --git a/chrome/browser/content_settings/permission_context_base.cc b/chrome/browser/content_settings/permission_context_base.cc

index a22e368d07e939950651085ebbd73960eb925324..f0c1d4c114407564ce7b31ae629bf781c69ec4e3 100644

--- a/chrome/browser/content_settings/permission_context_base.cc

+++ b/chrome/browser/content_settings/permission_context_base.cc

@@ -91,7 +91,6 @@ void PermissionContextBase::DecidePermission(

default:

break;

}

Bernhard Bauer 2014/07/08 15:31:20 Can you revert this change now that this CL doesn'

UMA_HISTOGRAM_ENUMERATION("ContentSettings.PermissionRequested",

SettingToPermission(permission_type_),

PERMISSION_NUM);

« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_context_base_unittest.cc » ('j') | no next file with comments »