Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: net/quic/crypto/local_strike_register_client_test.cc

Issue 371213002: Fixes for re-enabling more MSVC level 4 warnings: net/quic/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_protocol.h ('k') | net/quic/crypto/strike_register.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/local_strike_register_client_test.cc
diff --git a/net/quic/crypto/local_strike_register_client_test.cc b/net/quic/crypto/local_strike_register_client_test.cc
index 268e714d612127ecc9b6c97380ee9843e6c8a431..322a106c375c48d82fd2f59ae402fcace32a9a9b 100644
--- a/net/quic/crypto/local_strike_register_client_test.cc
+++ b/net/quic/crypto/local_strike_register_client_test.cc
@@ -83,8 +83,8 @@ TEST_F(LocalStrikeRegisterClientTest, IncorrectNonceLength) {
{
// Validation fails if you remove a byte from the nonce.
- bool called;
- bool is_valid;
+ bool called = false;
+ bool is_valid = false;
string short_nonce = valid_nonce.substr(0, valid_nonce.length() - 1);
strike_register_->VerifyNonceIsValidAndUnique(
short_nonce,
@@ -96,8 +96,8 @@ TEST_F(LocalStrikeRegisterClientTest, IncorrectNonceLength) {
{
// Validation fails if you add a byte to the nonce.
- bool called;
- bool is_valid;
+ bool called = false;
+ bool is_valid = false;
string long_nonce(valid_nonce);
long_nonce.append("a");
strike_register_->VerifyNonceIsValidAndUnique(
@@ -110,8 +110,8 @@ TEST_F(LocalStrikeRegisterClientTest, IncorrectNonceLength) {
{
// Verify that the base nonce validates was valid.
- bool called;
- bool is_valid;
+ bool called = false;
+ bool is_valid = false;
strike_register_->VerifyNonceIsValidAndUnique(
valid_nonce,
QuicWallTime::FromUNIXSeconds(kCurrentTimeExternalSecs),
« no previous file with comments | « net/quic/crypto/crypto_protocol.h ('k') | net/quic/crypto/strike_register.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698