Fixes for re-enabling more MSVC level 4 warnings: net/quic/ edition

net/quic/quic_server_id_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_server_id.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 using std::string;
 
@@ skipping 80 matching lines @@
   EXPECT_FALSE(a_10_http_private  < a_10_http_private);
   EXPECT_TRUE(a_10_http_private   < a_10_https_private);
   EXPECT_FALSE(a_10_https_private < a_10_http_private);
   EXPECT_FALSE(a_10_https_private < a_10_https_private);
 
   // Test with either host, port or https being different on left and right side
   // of less than.
   PrivacyMode left_privacy;
   PrivacyMode right_privacy;
   for (int i = 0; i < 4; i++) {
-    switch (i) {
-      case 0:
-        left_privacy = PRIVACY_MODE_DISABLED;
-        right_privacy = PRIVACY_MODE_DISABLED;
-        break;
-      case 1:
-        left_privacy = PRIVACY_MODE_DISABLED;
-        right_privacy = PRIVACY_MODE_ENABLED;
-        break;
-      case 2:
-        left_privacy = PRIVACY_MODE_ENABLED;
-        right_privacy = PRIVACY_MODE_DISABLED;
-        break;
-      case 3:
-        left_privacy = PRIVACY_MODE_ENABLED;
-        right_privacy = PRIVACY_MODE_ENABLED;
-        break;
-    }
+    left_privacy = static_cast<PrivacyMode>(i / 2);
+    right_privacy = static_cast<PrivacyMode>(i % 2);
     QuicServerId a_10_http_left_private(HostPortPair("a.com", 10), false,
                                         left_privacy);
     QuicServerId a_10_http_right_private(HostPortPair("a.com", 10), false,
                                          right_privacy);
     QuicServerId a_10_https_left_private(HostPortPair("a.com", 10), true,
                                          left_privacy);
     QuicServerId a_10_https_right_private(HostPortPair("a.com", 10), true,
                                           right_privacy);
     QuicServerId a_11_http_left_private(HostPortPair("a.com", 11), false,
                                         left_privacy);
@@ skipping 80 matching lines @@
     EXPECT_FALSE(b_11_http_left_private  < b_10_https_right_private);
     EXPECT_FALSE(b_11_https_left_private < b_10_http_right_private);
     EXPECT_FALSE(b_11_https_left_private < b_10_https_right_private);
   }
 }
 
 TEST(QuicServerIdTest, Equals) {
   PrivacyMode left_privacy;
   PrivacyMode right_privacy;
   for (int i = 0; i < 2; i++) {
-    switch (i) {
-      case 0:
-        left_privacy = PRIVACY_MODE_DISABLED;
-        right_privacy = PRIVACY_MODE_DISABLED;
-        break;
-      case 1:
-        left_privacy = PRIVACY_MODE_ENABLED;
-        right_privacy = PRIVACY_MODE_ENABLED;
-        break;
-    }
+    left_privacy = right_privacy = static_cast<PrivacyMode>(i);
     QuicServerId a_10_http_right_private(HostPortPair("a.com", 10), false,
                                          right_privacy);
     QuicServerId a_10_https_right_private(HostPortPair("a.com", 10), true,
                                           right_privacy);
     QuicServerId a_11_http_right_private(HostPortPair("a.com", 11), false,
                                          right_privacy);
     QuicServerId a_11_https_right_private(HostPortPair("a.com", 11), true,
                                           right_privacy);
     QuicServerId b_10_http_right_private(HostPortPair("b.com", 10), false,
                                          right_privacy);
@@ skipping 25 matching lines @@
     EXPECT_EQ(new_a_10_https_left_private, a_10_https_right_private);
     EXPECT_EQ(new_a_11_http_left_private,  a_11_http_right_private);
     EXPECT_EQ(new_a_11_https_left_private, a_11_https_right_private);
     EXPECT_EQ(new_b_10_http_left_private,  b_10_http_right_private);
     EXPECT_EQ(new_b_10_https_left_private, b_10_https_right_private);
     EXPECT_EQ(new_b_11_http_left_private,  b_11_http_right_private);
     EXPECT_EQ(new_b_11_https_left_private, b_11_https_right_private);
   }
 
   for (int i = 0; i < 2; i++) {
-    switch (i) {
-      case 0:
-        right_privacy = PRIVACY_MODE_DISABLED;
-        break;
-      case 1:
-        right_privacy = PRIVACY_MODE_ENABLED;
-        break;
-    }
+    right_privacy = static_cast<PrivacyMode>(i);
     QuicServerId a_10_http_right_private(HostPortPair("a.com", 10), false,
                                          right_privacy);
     QuicServerId a_10_https_right_private(HostPortPair("a.com", 10), true,
                                           right_privacy);
     QuicServerId a_11_http_right_private(HostPortPair("a.com", 11), false,
                                          right_privacy);
     QuicServerId a_11_https_right_private(HostPortPair("a.com", 11), true,
                                           right_privacy);
     QuicServerId b_10_http_right_private(HostPortPair("b.com", 10), false,
                                          right_privacy);
@@ skipping 18 matching lines @@
   QuicServerId a_10_http_private(HostPortPair("a.com", 10), false,
                                  PRIVACY_MODE_ENABLED);
   QuicServerId new_a_10_http_no_private(HostPortPair("a.com", 10), false,
                                         PRIVACY_MODE_DISABLED);
   EXPECT_FALSE(new_a_10_http_no_private == a_10_http_private);
 }
 
 }  // namespace
 
 }  // namespace net