Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 371133004: Update isSelectionEditable to be more broadly useful. (Closed)

Created:
6 years, 5 months ago by Donn Denman
Modified:
6 years, 5 months ago
Reviewers:
jdduke (slow), donnd
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add isFocusedNodeEditable to determine editability of the focus. This will be useful for Contextual Search to determine when to trigger. BUG=391973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281857

Patch Set 1 #

Total comments: 1

Patch Set 2 : Using separate isFocusedNodeEditable instead of changing isSelectionEditable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 6 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Donn Denman
Jared, PTAL. Thanks!
6 years, 5 months ago (2014-07-08 16:06:54 UTC) #1
jdduke (slow)
https://codereview.chromium.org/371133004/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/371133004/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1110 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1110: return mSelectionEditable; This seems ok, but it looks like ...
6 years, 5 months ago (2014-07-08 16:25:41 UTC) #2
jdduke (slow)
lgtm
6 years, 5 months ago (2014-07-08 17:05:51 UTC) #3
donnd
The CQ bit was checked by donnd@google.com
6 years, 5 months ago (2014-07-08 17:12:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/donnd@chromium.org/371133004/20001
6 years, 5 months ago (2014-07-08 17:13:39 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 22:51:15 UTC) #6
Message was sent while issue was closed.
Change committed as 281857

Powered by Google App Engine
This is Rietveld 408576698