Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: Tools/GardeningServer/ui/ct-failing-builders-tests.html

Issue 371133003: Add failed builders to sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: some cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failing-builders-tests.html
diff --git a/Tools/GardeningServer/ui/ct-failing-builders-tests.html b/Tools/GardeningServer/ui/ct-failing-builders-tests.html
new file mode 100644
index 0000000000000000000000000000000000000000..461145fa2f5c319f5d4ecfb6e884f3b711029a75
--- /dev/null
+++ b/Tools/GardeningServer/ui/ct-failing-builders-tests.html
@@ -0,0 +1,37 @@
+<!--
+Copyright 2014 The Chromium Authors. All rights reserved.
+Use of this source code is governed by a BSD-style license that can be
+found in the LICENSE file.
+-->
+
+<link rel="import" href="ct-failing-builders.html">
+
+<script>
+(function () {
+
+var kExampleBuilders = {
+ 'Win7 (dbg)': ['compile'],
+ 'WebKit Mac10.6 (dbg)': ['content_browsertests', 'unit_tests'],
+ 'WebKit XP': ['runhooks', 'webkit_unit_tests', 'webkit_lint'],
+};
+
+module("ct-failing-builders");
+
+asyncTest("basic", 3, function() {
+ var el = document.createElement('ct-failing-builders');
+ el.builders = kExampleBuilders;
+
+ el.async(function() {
michaelpg 2014/07/08 23:44:38 This works. But still waiting to hear from someone
ojan 2014/07/10 02:26:43 I'm also not sure what Platform.endOfMicroTask act
michaelpg 2014/07/10 02:53:28 The problem is endOfMicrotask doesn't actually do
+ var builders = el.shadowRoot.querySelectorAll('ct-builder');
+ for (var i = 0; i < builders.length; i++) {
+ var steps = builders[i].shadowRoot.querySelector('.details');
+ ok(steps.innerText == 'compile' ||
ojan 2014/07/10 02:26:43 Nit: use textContent. innerText is super crazy (e.
michaelpg 2014/07/10 02:53:28 Done, sorry, I knew this already.
+ steps.innerText == 'content_browsertests, unit_tests' ||
+ steps.innerText == 'runhooks, webkit_unit_tests, webkit_lint');
+ }
+ start();
+ });
+});
+
+})()
+</script>

Powered by Google App Engine
This is Rietveld 408576698