Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: Tools/GardeningServer/ui/ct-failure-analyzer.html

Issue 371133003: Add failed builders to sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: async instead of endMicrotask Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-analyzer.html
diff --git a/Tools/GardeningServer/ui/ct-failure-analyzer.html b/Tools/GardeningServer/ui/ct-failure-analyzer.html
index c6c04d0ff7460d0fb3f8ae12cb3be22b5808856b..7651748aac0d9247300896241862cb2e45bce01f 100644
--- a/Tools/GardeningServer/ui/ct-failure-analyzer.html
+++ b/Tools/GardeningServer/ui/ct-failure-analyzer.html
@@ -7,22 +7,32 @@ found in the LICENSE file.
<polymer-element name="ct-failure-analyzer" attributes="failures status">
<script>
Polymer({
- failures: [],
-
- pendingFailures: [],
+ failures: {},
+ pendingUnexpectedFailures: [],
update: function() {
- this.pendingFailures = [];
+ this._updateFailingBuilders();
+ this._updateUnexpectedFailures();
+ },
+
+ _updateFailingBuilders: function() {
+ builders.buildersFailingNonLayoutTests().then((function(builders) {
+ this.failures.builders = builders;
+ }).bind(this));
+ },
+
+ _updateUnexpectedFailures: function() {
+ this.pendingUnexpectedFailures = [];
var numberOfTestsAnalyzed = 0;
this.status = 'Updating ...';
Promise.all([model.updateRecentCommits(), model.updateResultsByBuilder()]).then(function() {
this.status = 'Analyzing test failures ...';
model.analyzeUnexpectedFailures(function(failureAnalysis, total) {
this.status = 'Analyzing test failures ... ' + ++numberOfTestsAnalyzed + '/' + total + ' tests analyzed.';
- this.pendingFailures.push(failureAnalysis);
+ this.pendingUnexpectedFailures.push(failureAnalysis);
}.bind(this)).then(function() {
this.status = 'Done!!!';
- this.failures = this.pendingFailures;
+ this.failures.unexpected = this.pendingUnexpectedFailures;
}.bind(this));
}.bind(this));
},
« no previous file with comments | « Tools/GardeningServer/ui/ct-failing-builders-tests.html ('k') | Tools/GardeningServer/ui/ct-unexpected-failures.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698