Add failed builders to sheriff-o-matic.

Tools/GardeningServer/ui/ct-failing-builders-tests.html

Index: Tools/GardeningServer/ui/ct-failing-builders-tests.html
diff --git a/Tools/GardeningServer/ui/ct-failing-builders-tests.html b/Tools/GardeningServer/ui/ct-failing-builders-tests.html
new file mode 100644
index 0000000000000000000000000000000000000000..4b02e8ec175400c73f2def45ef1053c18dc4e930
--- /dev/null
+++ b/Tools/GardeningServer/ui/ct-failing-builders-tests.html
@@ -0,0 +1,44 @@
+<!--
+Copyright 2014 The Chromium Authors. All rights reserved.
+Use of this source code is governed by a BSD-style license that can be
+found in the LICENSE file.
+-->
+
+<link rel="import" href="ct-failing-builders.html">
+
+<script>
+(function () {
+
+var kExampleBuilders = {
+    'Win7 (dbg)': ['compile'],
+    'WebKit Mac10.6 (dbg)': ['content_browsertests', 'unit_tests'],
+    'WebKit XP': ['runhooks', 'webkit_unit_tests', 'webkit_lint'],
+};
+
+module("ct-failing-builders");
+
+asyncTest("basic", 3, function() {
+  var el = document.createElement('ct-failing-builders');
+  el.builders = kExampleBuilders;
+  window.el = el;
+  Platform.endOfMicrotask(function() {
+    var builders = el.shadowRoot.querySelectorAll('ct-builder');
+
+    // todo: make this work without the timeout!
+    window.setTimeout((function() {
+
+    for (var i = 0; i < builders.length; i++) {
+      var steps = builders[i].shadowRoot.querySelector('.details');
+      ok(steps.innerText == 'compile' ||

[michaelpg, 2014/07/07 23:15:20]

Without the timeout, this throws:
    Uncaught TypeError: Cannot read property 'innerText' of null

In each <ct-builder>'s shadow root, I see that the builderName attribute is
correctly placed into the DOM, but the stepList property is not. The debugger
shows that the ct-builder's stepList property is getting set inside the element,
but it just doesn't appear in the shadow root until some time has passed.

How can I account for this in the test?

<template>
....
  <template if="{{ stepList }}">   
    <span class="details">{{ stepList }}</span>    
  </template> 
  <!-- "details" span is not created yet but this.stepList is a truthy string
-->     
....
</template>

[abarth-chromium, 2014/07/07 23:56:05]

Maybe call Platform.endOfMicrotask again instead of setTimeout?

[michaelpg, 2014/07/07 23:58:17]

I'm not sure what endOfMicrotask does (haven't found documentation and the code
is minified). I tried adding another call inside of the outer endOfMicrotask
call but it didn't seem to have an effect.

+         steps.innerText == 'content_browsertests, unit_tests' ||
+         steps.innerText == 'runhooks, webkit_unit_tests, webkit_lint');
+    }
+    start();
+
+    // todo: make this work without the timeout!
+    }).bind(this), 500);
+  });
+});
+
+})()
+</script>