Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Tools/GardeningServer/ui/ct-failing-builders-tests.html

Issue 371133003: Add failed builders to sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: some cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file.
5 -->
6
7 <link rel="import" href="ct-failing-builders.html">
8
9 <script>
10 (function () {
11
12 var kExampleBuilders = {
13 'Win7 (dbg)': ['compile'],
14 'WebKit Mac10.6 (dbg)': ['content_browsertests', 'unit_tests'],
15 'WebKit XP': ['runhooks', 'webkit_unit_tests', 'webkit_lint'],
16 };
17
18 module("ct-failing-builders");
19
20 asyncTest("basic", 3, function() {
21 var el = document.createElement('ct-failing-builders');
22 el.builders = kExampleBuilders;
23
24 el.async(function() {
michaelpg 2014/07/08 23:44:38 This works. But still waiting to hear from someone
ojan 2014/07/10 02:26:43 I'm also not sure what Platform.endOfMicroTask act
michaelpg 2014/07/10 02:53:28 The problem is endOfMicrotask doesn't actually do
25 var builders = el.shadowRoot.querySelectorAll('ct-builder');
26 for (var i = 0; i < builders.length; i++) {
27 var steps = builders[i].shadowRoot.querySelector('.details');
28 ok(steps.innerText == 'compile' ||
ojan 2014/07/10 02:26:43 Nit: use textContent. innerText is super crazy (e.
michaelpg 2014/07/10 02:53:28 Done, sorry, I knew this already.
29 steps.innerText == 'content_browsertests, unit_tests' ||
30 steps.innerText == 'runhooks, webkit_unit_tests, webkit_lint');
31 }
32 start();
33 });
34 });
35
36 })()
37 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698