Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: components/translate/core/browser/translate_ui_delegate.cc

Issue 371113002: Fixes for re-enabling more MSVC level 4 warnings: components/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attempt to fix compile failure Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate.cc
diff --git a/components/translate/core/browser/translate_ui_delegate.cc b/components/translate/core/browser/translate_ui_delegate.cc
index 1c4c869b962d671dc775a05c831e0b771f3475be..3cbcff3581b6a601fbb44801ab438b5c76f5400a 100644
--- a/components/translate/core/browser/translate_ui_delegate.cc
+++ b/components/translate/core/browser/translate_ui_delegate.cc
@@ -38,9 +38,9 @@ TranslateUIDelegate::TranslateUIDelegate(
: translate_driver_(
translate_manager->translate_client()->GetTranslateDriver()),
translate_manager_(translate_manager),
- original_language_index_(NO_INDEX),
- initial_original_language_index_(NO_INDEX),
- target_language_index_(NO_INDEX) {
+ original_language_index_(kNoIndex),
+ initial_original_language_index_(kNoIndex),
+ target_language_index_(kNoIndex) {
DCHECK(translate_driver_);
DCHECK(translate_manager_);
@@ -140,16 +140,16 @@ std::string TranslateUIDelegate::GetLanguageCodeAt(size_t index) const {
}
base::string16 TranslateUIDelegate::GetLanguageNameAt(size_t index) const {
- if (index == static_cast<size_t>(NO_INDEX))
+ if (index == kNoIndex)
return base::string16();
DCHECK_LT(index, GetNumberOfLanguages());
return languages_[index].second;
}
std::string TranslateUIDelegate::GetOriginalLanguageCode() const {
- return (GetOriginalLanguageIndex() == static_cast<size_t>(NO_INDEX))
- ? translate::kUnknownLanguageCode
- : GetLanguageCodeAt(GetOriginalLanguageIndex());
+ return (GetOriginalLanguageIndex() == kNoIndex) ?
+ translate::kUnknownLanguageCode :
+ GetLanguageCodeAt(GetOriginalLanguageIndex());
}
std::string TranslateUIDelegate::GetTargetLanguageCode() const {
« no previous file with comments | « components/translate/core/browser/translate_ui_delegate.h ('k') | components/url_matcher/substring_set_matcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698