src/gpu/effects/GrDitherEffect.cpp - Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrDitherEffect.cpp

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2

Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrDitherEffect.cpp

diff --git a/src/gpu/effects/GrDitherEffect.cpp b/src/gpu/effects/GrDitherEffect.cpp

index 7409e5ff7151818442b74ed68938d27ec38cd9b0..1db61ba146dc3f3dfe86f88d9ebaea6114f3ab72 100644

--- a/src/gpu/effects/GrDitherEffect.cpp

+++ b/src/gpu/effects/GrDitherEffect.cpp

@@ -20,7 +20,8 @@ class GLDitherEffect;

class DitherEffect : public GrEffect {

public:

static GrEffectRef* Create() {

- return CreateEffectRef(AutoEffectUnref(SkNEW(DitherEffect)));

+ GR_CREATE_STATIC_EFFECT(gDitherEffect, DitherEffect, ())

+ return SkRef(gDitherEffect);

}

virtual ~DitherEffect() {};

« no previous file with comments | « src/gpu/effects/GrDistanceFieldTextureEffect.h ('k') | src/gpu/effects/GrOvalEffect.cpp » ('j') | no next file with comments »