Mac: remove spurious toolbar context menu and associated crash.

Mac: remove spurious toolbar context menu and associated crash.

The toolbar should not have a context menu, and it should decidedly not be hooked up to the Page menu.

Changes to Toolbar.xib:
- remove the connection from the Toolbar |menu| outlet (to the Page Menu)
- connect Chrome UI Localizer's |yetAnotherObjectToLocalize_| outlet to the Page Menu

BUG=26823
TEST=See bug. Also, make sure the toolbar does NOT have a context menu, and that the Page Menu is displayed correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31370

[Nico, 2009-11-07 04:56:55]

LG!

Yikes, where did that come from? :-)

[TVL, 2009-11-09 03:57:17]

Did you happen to see how it came in?  I've been worried we'd get odd things
from someone editing on one OS version and pushing and that merging oddly with
an edit on the other OS version (because of the changes in xib format with 3.2
vs 3.1.x).  Just wondering if that's what happened here.

[viettrungluu, 2009-11-09 06:01:26]

I'll check when I have a moment. It's possible that it's always been that way
though -- it wasn't hooked up to the UI localizer, so the only way the Page menu
was being displayed properly was by being set as a context menu.

On 2009/11/09 03:57:17, TVL wrote:
> Did you happen to see how it came in?  I've been worried we'd get odd things
> from someone editing on one OS version and pushing and that merging oddly with
> an edit on the other OS version (because of the changes in xib format with 3.2
> vs 3.1.x).  Just wondering if that's what happened here.

[akalin, 2009-11-12 10:36:26]

On 2009/11/09 06:01:26, viettrungluu wrote:
> I'll check when I have a moment. It's possible that it's always been that way
> though -- it wasn't hooked up to the UI localizer, so the only way the Page
menu
> was being displayed properly was by being set as a context menu.
> 
> On 2009/11/09 03:57:17, TVL wrote:
> > Did you happen to see how it came in?  I've been worried we'd get odd things
> > from someone editing on one OS version and pushing and that merging oddly
with
> > an edit on the other OS version (because of the changes in xib format with
3.2
> > vs 3.1.x).  Just wondering if that's what happened here.

This removed the sync-related menu items ( from
http://codereview.chromium.org/363017 ). :( I will send out a CL to add it back
in.

[pink (ping after 24hrs), 2009-11-12 15:16:06]

How did that happen? Did we get merge issues with svn and the xib
file? I'd like to understand what went wrong so we can watch out for
it in the future. We haven't had any of these kinds of issues to date.

On Thu, Nov 12, 2009 at 5:36 AM,  <akalin@chromium.org> wrote:
> On 2009/11/09 06:01:26, viettrungluu wrote:
>>
>> I'll check when I have a moment. It's possible that it's always been tha=
t
>> way
>> though -- it wasn't hooked up to the UI localizer, so the only way the
>> Page
>
> menu
>>
>> was being displayed properly was by being set as a context menu.
>
>> On 2009/11/09 03:57:17, TVL wrote:
>> > Did you happen to see how it came in? =A0I've been worried we'd get od=
d
>> > things
>> > from someone editing on one OS version and pushing and that merging
>> > oddly
>
> with
>>
>> > an edit on the other OS version (because of the changes in xib format
>> > with
>
> 3.2
>>
>> > vs 3.1.x). =A0Just wondering if that's what happened here.
>
> This removed the sync-related menu items ( from
> http://codereview.chromium.org/363017 ). :( I will send out a CL to add i=
t
> back
> in.
>
> http://codereview.chromium.org/371049
>



--=20
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[viettrungluu, 2009-11-12 15:44:17]

I have no idea. I don't recall any non-automatic merges being involved, and I
definitely didn't manually remove the sync menu items. I'll check my local git
repository....

On 2009/11/12 15:16:06, pink wrote:
> How did that happen? Did we get merge issues with svn and the xib
> file? I'd like to understand what went wrong so we can watch out for
> it in the future. We haven't had any of these kinds of issues to date.
> 
> > This removed the sync-related menu items ( from
> > http://codereview.chromium.org/363017 ). :( I will send out a CL to add i=
> t
> > back
> > in.
> >
> > http://codereview.chromium.org/371049

[viettrungluu, 2009-11-12 15:55:38]

In the absence of any other explanation, I suspect that when I re-did my changes
(after a conflict), I started from the wrong version of Toolbar.xib. <sigh>
Probably I should have looked at the diff afterwards to make sure that it was
what I expected.

On 2009/11/12 15:44:17, viettrungluu wrote:
> I have no idea. I don't recall any non-automatic merges being involved, and I
> definitely didn't manually remove the sync menu items. I'll check my local git
> repository....
> 
> On 2009/11/12 15:16:06, pink wrote:
> > How did that happen? Did we get merge issues with svn and the xib
> > file? I'd like to understand what went wrong so we can watch out for
> > it in the future. We haven't had any of these kinds of issues to date.
> > 
> > > This removed the sync-related menu items ( from
> > > http://codereview.chromium.org/363017 ). :( I will send out a CL to add i=
> > t
> > > back
> > > in.
> > >
> > > http://codereview.chromium.org/371049