Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 371033005: Remove unused LOGGED_IN_OOBE LoggedInState. (Closed)

Created:
6 years, 5 months ago by Thiemo Nagel
Modified:
6 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused LOGGED_IN_OOBE LoggedInState. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282645

Patch Set 1 #

Patch Set 2 : Remove no-op in ShowLoginWizard(). #

Patch Set 3 : Adapt unit tests. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 3 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/login/login_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login/login_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Thiemo Nagel
Hi Nikita and Mitsuru, could you please take a look at this small cleanup, as ...
6 years, 5 months ago (2014-07-07 19:11:02 UTC) #1
Nikita (slow)
lgtm
6 years, 5 months ago (2014-07-07 21:07:46 UTC) #2
Nikita (slow)
lgtm lgtm
6 years, 5 months ago (2014-07-07 21:07:46 UTC) #3
oshima
lgtm
6 years, 5 months ago (2014-07-07 21:19:49 UTC) #4
Thiemo Nagel
On 2014/07/07 21:19:49, oshima wrote: > lgtm I just realized that SetLoggedInState() can be completely ...
6 years, 5 months ago (2014-07-08 08:39:30 UTC) #5
Nikita (slow)
On 2014/07/08 08:39:30, Thiemo Nagel wrote: > On 2014/07/07 21:19:49, oshima wrote: > > lgtm ...
6 years, 5 months ago (2014-07-08 08:57:56 UTC) #6
Thiemo Nagel
> sgtm Thank you!
6 years, 5 months ago (2014-07-08 09:31:21 UTC) #7
Thiemo Nagel
Hi Jun, could you please take a look whether you agree with the changes to ...
6 years, 5 months ago (2014-07-10 12:36:05 UTC) #8
Jun Mukai
notification lgtm
6 years, 5 months ago (2014-07-10 17:06:47 UTC) #9
Thiemo Nagel
On 2014/07/10 17:06:47, Jun Mukai wrote: > notification lgtm Thank you!
6 years, 5 months ago (2014-07-11 11:41:51 UTC) #10
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 5 months ago (2014-07-11 11:41:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/371033005/40001
6 years, 5 months ago (2014-07-11 11:42:30 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 12:25:05 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 12:26:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/169437) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/158473) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-11 12:26:38 UTC) #15
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 5 months ago (2014-07-11 12:33:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/371033005/60001
6 years, 5 months ago (2014-07-11 12:34:36 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 17:45:21 UTC) #18
Message was sent while issue was closed.
Change committed as 282645

Powered by Google App Engine
This is Rietveld 408576698