src/arm64/debug-arm64.cc - Issue 371033002: Reland r22247 "ARM64: Use UntagSmi helpers and clean up assertions."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/debug-arm64.cc

Issue 371033002: Reland r22247 "ARM64: Use UntagSmi helpers and clean up assertions." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix more failures. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/debug-arm64.cc

diff --git a/src/arm64/debug-arm64.cc b/src/arm64/debug-arm64.cc

index 43684d5157e1b6020daf1083c000bf3c6cdf1018..157845213856b1a2f5fcdcc54272af45a93266c8 100644

--- a/src/arm64/debug-arm64.cc

+++ b/src/arm64/debug-arm64.cc

@@ -171,7 +171,8 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

// jssp[8]: 0x00000000 (SMI tag & padding)

// jssp[4]: reg[31:0]

// jssp[0]: 0x00000000 (SMI tag & padding)

- STATIC_ASSERT((kSmiTag == 0) && (kSmiShift == 32));

+ STATIC_ASSERT(kSmiTag == 0);

+ STATIC_ASSERT(static_cast<unsigned>(kSmiShift) == kWRegSizeInBits);

}

if (object_regs != 0) {

« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »