Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 371033002: Reland r22247 "ARM64: Use UntagSmi helpers and clean up assertions." (Closed)

Created:
6 years, 5 months ago by jbramley
Modified:
6 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland r22247 "ARM64: Use UntagSmi helpers and clean up assertions." BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22282

Patch Set 1 #

Patch Set 2 : Fix more failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M src/arm64/assembler-arm64-inl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/arm64/debug-arm64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbramley
This fixes the warnings raised by some versions of GCC by casting types to make ...
6 years, 5 months ago (2014-07-08 08:26:23 UTC) #1
ulan
lgtm
6 years, 5 months ago (2014-07-08 08:28:38 UTC) #2
jbramley
6 years, 5 months ago (2014-07-08 14:15:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698