Issue 371015: Linux: Catch plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371015: Linux: Catch plugin crashes. (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: Catch plugin crashes. BUG=25964 TEST=none r31416

Patch Set 1 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+176 lines, -433 lines)			Patch
M	chrome/app/breakpad_linux.cc	View	5 chunks	+11 lines, -7 lines	0 comments	Download
A +	chrome/browser/crash_handler_host_linux.h	View	2 chunks	+58 lines, -18 lines	1 comment	Download
A +	chrome/browser/crash_handler_host_linux.cc	View	10 chunks	+26 lines, -29 lines	0 comments	Download
A +	chrome/browser/crash_handler_host_linux_stub.cc	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/plugin_process_host.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View	6 chunks	+43 lines, -37 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	5 chunks	+3 lines, -6 lines	0 comments	Download
D	chrome/browser/renderer_host/render_crash_handler_host_linux.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	chrome/browser/renderer_host/render_crash_handler_host_linux.cc	View	1 chunk	+0 lines, -245 lines	0 comments	Download
D	chrome/browser/renderer_host/render_crash_handler_host_linux_stub.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	chrome/chrome.gyp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/plugin/DEPS	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	chrome/plugin/plugin_main.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 1 month ago (2009-11-06 20:00:22 UTC) #2

LGTM, nice job. I hope navigating all that wasn't too bad.

http://codereview.chromium.org/371015/diff/4001/4009
File chrome/browser/crash_handler_host_linux.h (right):

http://codereview.chromium.org/371015/diff/4001/4009#newcode13
Line 13: // This is the base class for singleton objects which crash dumps
renderers and
s/dumps/dump/

Expand Messages | Collapse Messages