Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 371013002: Temporarily adding timers to one WebRTC browsertest. (Closed)

Created:
6 years, 5 months ago by phoglund_chromium
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Temporarily adding timers to one WebRTC browsertest. Perhaps then we can see where it gets stuck or slowed down on Android bots. BUG=387895 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281518

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 5 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
phoglund_chromium
6 years, 5 months ago (2014-07-07 08:50:41 UTC) #1
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 5 months ago (2014-07-07 08:50:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/371013002/1
6 years, 5 months ago (2014-07-07 08:51:58 UTC) #3
tommi (sloooow) - chröme
https://codereview.chromium.org/371013002/diff/1/content/browser/media/webrtc_getusermedia_browsertest.cc File content/browser/media/webrtc_getusermedia_browsertest.cc (right): https://codereview.chromium.org/371013002/diff/1/content/browser/media/webrtc_getusermedia_browsertest.cc#newcode86 content/browser/media/webrtc_getusermedia_browsertest.cc:86: LOG(INFO) << "Entering teardown; " << timer_.Elapsed().InSeconds() We don't ...
6 years, 5 months ago (2014-07-07 09:35:07 UTC) #4
phoglund_chromium
https://codereview.chromium.org/371013002/diff/1/content/browser/media/webrtc_getusermedia_browsertest.cc File content/browser/media/webrtc_getusermedia_browsertest.cc (right): https://codereview.chromium.org/371013002/diff/1/content/browser/media/webrtc_getusermedia_browsertest.cc#newcode86 content/browser/media/webrtc_getusermedia_browsertest.cc:86: LOG(INFO) << "Entering teardown; " << timer_.Elapsed().InSeconds() On 2014/07/07 ...
6 years, 5 months ago (2014-07-07 09:48:40 UTC) #5
tommi (sloooow) - chröme
ok, lgtm
6 years, 5 months ago (2014-07-07 10:07:22 UTC) #6
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 5 months ago (2014-07-07 11:07:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/371013002/20001
6 years, 5 months ago (2014-07-07 11:08:09 UTC) #8
commit-bot: I haz the power
Change committed as 281518
6 years, 5 months ago (2014-07-07 11:09:05 UTC) #9
eseidel
This broke content_browsertests on at least win7: https://build.chromium.org/p/chromium.webkit/builders/Win7%20(dbg)/builds/14477/steps/content_browsertests/logs/stdio
6 years, 5 months ago (2014-07-07 22:04:24 UTC) #10
eseidel
A revert of this CL has been created in https://codereview.chromium.org/377763002/ by eseidel@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-07 22:04:49 UTC) #11
phoglund_chromium
6 years, 5 months ago (2014-07-08 07:34:21 UTC) #12
Message was sent while issue was closed.
On 2014/07/07 22:04:49, eseidel wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/377763002/ by mailto:eseidel@chromium.org.
> 
> The reason for reverting is: Broke content_browsertests on win7:
>
https://build.chromium.org/p/chromium.webkit/builders/Win7%20(dbg)/builds/144....

Huh, that's weird. Anyway, thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698