Issue 370973002: Properly seed the RNG for cctest/test-types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 370973002: Properly seed the RNG for cctest/test-types. (Closed)

Created:
6 years, 5 months ago by Benedikt Meurer

Modified:
6 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Properly seed the RNG for cctest/test-types. This was broken since r21879, as the RandomNumberGenerator constructor does no longer look at FLAG_random_seed implicitly. TEST=cctest/test-types R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22222

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -36 lines)			Patch
	M	src/arguments.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/cctest/test-types.cc	View		7 chunks	+14 lines, -36 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

6 years, 5 months ago (2014-07-07 07:04:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22222 (presubmit successful).