core/src/fpdfdoc/tagged_int.h - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/tagged_int.h

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfdoc/tagged_int.h

diff --git a/core/src/fpdfdoc/tagged_int.h b/core/src/fpdfdoc/tagged_int.h

index 0ebf4084a4391343901d1ab9aa117a22ec15153a..d190db6427a244463d34fb1f10637be5fc536629 100644

--- a/core/src/fpdfdoc/tagged_int.h

+++ b/core/src/fpdfdoc/tagged_int.h

@@ -32,7 +32,7 @@ protected:

CFX_ArrayTemplate<CPDF_StructElementImpl*> m_Kids;

friend class CPDF_StructElementImpl;

};

-class CPDF_StructElementImpl : public CPDF_StructElement

+class CPDF_StructElementImpl FX_FINAL : public CPDF_StructElement

{

public:

CPDF_StructElementImpl(CPDF_StructTreeImpl* pTree, CPDF_StructElementImpl* pParent, CPDF_Dictionary* pDict);

« no previous file with comments | « core/src/fpdfapi/fpdf_font/ttgsubtable.h ('k') | core/src/fxcrt/extension.h » ('j') | no next file with comments »