core/include/fxcrt/fx_system.h - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxcrt/fx_system.h

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/include/fxcrt/fx_system.h

diff --git a/core/include/fxcrt/fx_system.h b/core/include/fxcrt/fx_system.h

index 9f43360fa7fb1c0f2cf8410b8708af65ae87ef4b..a757de4c5ee1b023fcf7e25630a7f55acefca612 100644

--- a/core/include/fxcrt/fx_system.h

+++ b/core/include/fxcrt/fx_system.h

@@ -275,5 +275,14 @@ int FXSYS_round(FX_FLOAT f);

#define FXSYS_sqrt2(a, b) (FX_FLOAT)FXSYS_sqrt((a)*(a) + (b)*(b))

#ifdef __cplusplus

};

+#if defined(__clang__) || defined(_MSC_VER)

+#define FX_FINAL final

+#elif defined(__GNUC__) && __cplusplus >= 201103 && \

+ (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700

+#define FX_FINAL final

+#else

+#define FX_FINAL

+#endif

#endif

« no previous file with comments | « core/include/fpdfapi/fpdf_parser.h ('k') | core/include/fxge/fx_font.h » ('j') | no next file with comments »