fpdfsdk/src/fpdf_sysfontinfo.cpp - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_sysfontinfo.cpp

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fpdf_sysfontinfo.cpp

diff --git a/fpdfsdk/src/fpdf_sysfontinfo.cpp b/fpdfsdk/src/fpdf_sysfontinfo.cpp

index 4c6b7849814f61e3cec6288fd3437d009225a033..cc75e635b3abbd5ccc4e9b219240e9603cfe1cc4 100644

--- a/fpdfsdk/src/fpdf_sysfontinfo.cpp

+++ b/fpdfsdk/src/fpdf_sysfontinfo.cpp

@@ -7,7 +7,7 @@

#include "../include/fsdk_define.h"

#include "../include/fpdf_sysfontinfo.h"

-class CSysFontInfo_Ext : public IFX_SystemFontInfo

+class CSysFontInfo_Ext FX_FINAL : public IFX_SystemFontInfo

{

public:

FPDF_SYSFONTINFO* m_pInfo;

« no previous file with comments | « fpdfsdk/include/fsdk_mgr.h ('k') | fpdfsdk/src/fpdfeditpage.cpp » ('j') | fpdfsdk/src/fpdfeditpage.cpp » ('J')