pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

fpdfsdk/include/fsdk_mgr.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FPDFSDK_MGR_H
 #define _FPDFSDK_MGR_H
 
 #include "fsdk_common.h"
@@ skipping 13 matching lines @@
 class CPDFSDK_PageView;
 class CPDFSDK_Annot;
 class CFFL_IFormFiller;
 class CPDFSDK_Widget;
 class IFX_SystemHandler;
 class CPDFSDK_ActionHandler;
 class CJS_RuntimeFactory;
 
 #include "javascript/IJavaScript.h"
 
-class CPDFDoc_Environment
+class CPDFDoc_Environment FX_FINAL
 {
 public:
         CPDFDoc_Environment(CPDF_Document * pDoc);
         ~CPDFDoc_Environment();
 
         int RegAppHandle(FPDF_FORMFILLINFO* pFFinfo);//{ m_pInfo  = pFFinfo; return TRUE;}
 
-        virtual void            Release()
-        {
-                if (m_pInfo && m_pInfo->Release)
-                        m_pInfo->Release(m_pInfo);
-                delete this;
-        }
-
-        virtual void FFI_Invalidate(FPDF_PAGE page, double left, double top, double right, double bottom)
+        void FFI_Invalidate(FPDF_PAGE page, double left, double top, double right, double bottom)
         {
                 if (m_pInfo && m_pInfo->FFI_Invalidate) 
                 {
                         m_pInfo->FFI_Invalidate(m_pInfo, page, left, top, right, bottom);
                 }
         }
-        virtual void FFI_OutputSelectedRect(FPDF_PAGE page, double left, double top, double right, double bottom)
+        void FFI_OutputSelectedRect(FPDF_PAGE page, double left, double top, double right, double bottom)
         {
                 if (m_pInfo && m_pInfo->FFI_OutputSelectedRect) 
                 {
                         m_pInfo->FFI_OutputSelectedRect(m_pInfo, page, left, top, right, bottom);
                 }
         }
 
-        virtual void FFI_SetCursor(int nCursorType)
+        void FFI_SetCursor(int nCursorType)
         {
                 if (m_pInfo && m_pInfo->FFI_SetCursor) 
                 {
                         m_pInfo->FFI_SetCursor(m_pInfo, nCursorType);
                 }
         }
 
-        virtual int  FFI_SetTimer(int uElapse, TimerCallback lpTimerFunc)
+        int  FFI_SetTimer(int uElapse, TimerCallback lpTimerFunc)
         {
                 if (m_pInfo && m_pInfo->FFI_SetTimer) 
                 {
                         return m_pInfo->FFI_SetTimer(m_pInfo, uElapse, lpTimerFunc);
                 }
                 return -1;
         }
                 
-        virtual void FFI_KillTimer(int nTimerID)
+        void FFI_KillTimer(int nTimerID)
         {
                 if (m_pInfo && m_pInfo->FFI_KillTimer) 
                 {
                         m_pInfo->FFI_KillTimer(m_pInfo, nTimerID);
                 }
         }
         FX_SYSTEMTIME FFI_GetLocalTime()
         {
                 FX_SYSTEMTIME fxtime;
                 if(m_pInfo && m_pInfo->FFI_GetLocalTime)
                 {
                         FPDF_SYSTEMTIME systime = m_pInfo->FFI_GetLocalTime(m_pInfo);
                         fxtime.wDay = systime.wDay;
                         fxtime.wDayOfWeek = systime.wDayOfWeek;
                         fxtime.wHour = systime.wHour;
                         fxtime.wMilliseconds = systime.wMilliseconds;
                         fxtime.wMinute = systime.wMinute;
                         fxtime.wMonth = systime.wMonth;
                         fxtime.wSecond = systime.wSecond;
                         fxtime.wYear = systime.wYear;
                 }
                 return fxtime;
         }
 
-        virtual void FFI_OnChange()
+        void FFI_OnChange()
         {
                 if(m_pInfo && m_pInfo->FFI_OnChange)
                 {
                         m_pInfo->FFI_OnChange(m_pInfo);
                 }
         }
 
-        virtual FX_BOOL FFI_IsSHIFTKeyDown(FX_DWORD nFlag)
+        FX_BOOL FFI_IsSHIFTKeyDown(FX_DWORD nFlag)
         {
                 
                 return (nFlag & FWL_EVENTFLAG_ShiftKey) != 0;
         }
-        virtual FX_BOOL FFI_IsCTRLKeyDown(FX_DWORD nFlag)
+        FX_BOOL FFI_IsCTRLKeyDown(FX_DWORD nFlag)
         {
 
                 return (nFlag & FWL_EVENTFLAG_ControlKey) != 0;
         }
-        virtual FX_BOOL FFI_IsALTKeyDown(FX_DWORD nFlag)
+        FX_BOOL FFI_IsALTKeyDown(FX_DWORD nFlag)
         {
 
                 return (nFlag & FWL_EVENTFLAG_AltKey) != 0;
         }
-        virtual FX_BOOL FFI_IsINSERTKeyDown(FX_DWORD nFlag)
+        FX_BOOL FFI_IsINSERTKeyDown(FX_DWORD nFlag)
         {
                 return FALSE;
         }
 
-        virtual int JS_appAlert(FX_LPCWSTR Msg, FX_LPCWSTR Title, FX_UINT Type, FX_UINT Icon)
+        int JS_appAlert(FX_LPCWSTR Msg, FX_LPCWSTR Title, FX_UINT Type, FX_UINT Icon)
         {
                 if(m_pInfo && m_pInfo->m_pJsPlatform && m_pInfo->m_pJsPlatform->app_alert)
                 {
                         CFX_ByteString bsMsg = CFX_WideString(Msg).UTF16LE_Encode();
                         CFX_ByteString bsTitle = CFX_WideString(Title).UTF16LE_Encode();
                         FPDF_WIDESTRING pMsg = (FPDF_WIDESTRING)bsMsg.GetBuffer(bsMsg.GetLength());
                         FPDF_WIDESTRING pTitle = (FPDF_WIDESTRING)bsTitle.GetBuffer(bsTitle.GetLength());
                         int ret = m_pInfo->m_pJsPlatform->app_alert(m_pInfo->m_pJsPlatform, pMsg, pTitle, Type, Icon);
                         bsMsg.ReleaseBuffer();
                         bsTitle.ReleaseBuffer();
                         return ret;
                 }
                 return -1;
         }
 
-        virtual int JS_appResponse(FX_LPCWSTR Question, FX_LPCWSTR Title, FX_LPCWSTR Default, FX_LPCWSTR cLabel, FPDF_BOOL bPassword, void* response, int length)
+        int JS_appResponse(FX_LPCWSTR Question, FX_LPCWSTR Title, FX_LPCWSTR Default, FX_LPCWSTR cLabel, FPDF_BOOL bPassword, void* response, int length)
         {
                 if (m_pInfo && m_pInfo->m_pJsPlatform && m_pInfo->m_pJsPlatform->app_response)
                 {
                         CFX_ByteString bsQuestion = CFX_WideString(Question).UTF16LE_Encode();
                         CFX_ByteString bsTitle = CFX_WideString(Title).UTF16LE_Encode();
                         CFX_ByteString bsDefault = CFX_WideString(Default).UTF16LE_Encode();
                         CFX_ByteString bsLabel = CFX_WideString(cLabel).UTF16LE_Encode();
                         FPDF_WIDESTRING pQuestion = (FPDF_WIDESTRING)bsQuestion.GetBuffer(bsQuestion.GetLength());
                         FPDF_WIDESTRING pTitle = (FPDF_WIDESTRING)bsTitle.GetBuffer(bsTitle.GetLength());
                         FPDF_WIDESTRING pDefault = (FPDF_WIDESTRING)bsDefault.GetBuffer(bsDefault.GetLength());
                         FPDF_WIDESTRING pLabel = (FPDF_WIDESTRING)bsLabel.GetBuffer(bsLabel.GetLength());
                         int ret = m_pInfo->m_pJsPlatform->app_response(m_pInfo->m_pJsPlatform, pQuestion, pTitle, 
                                 pDefault, pLabel, bPassword, response, length);
                         bsQuestion.ReleaseBuffer();
                         bsTitle.ReleaseBuffer();
                         bsDefault.ReleaseBuffer();
                         bsLabel.ReleaseBuffer();
                         return ret;
                 }
                 return -1;
         }
 
-        virtual void JS_appBeep(int nType)
+        void JS_appBeep(int nType)
         {
                 if(m_pInfo && m_pInfo->m_pJsPlatform && m_pInfo->m_pJsPlatform->app_beep)
                 {
                         m_pInfo->m_pJsPlatform->app_beep(m_pInfo->m_pJsPlatform, nType);
                 }
         }
 
-        virtual CFX_WideString JS_fieldBrowse()
+        CFX_WideString JS_fieldBrowse()
         {
                 if(m_pInfo && m_pInfo->m_pJsPlatform && m_pInfo->m_pJsPlatform->Field_browse)
                 {
                         int nLen = m_pInfo->m_pJsPlatform->Field_browse(m_pInfo->m_pJsPlatform, NULL, 0);
                         if(nLen <= 0)
                                 return L"";
                         char* pbuff = new char[nLen];
                         if(pbuff)
                                 memset(pbuff, 0, nLen);
                         else    
@@ skipping 84 matching lines @@
                 }
         }
         void JS_docgotoPage(int nPageNum)
         {
                 if(m_pInfo && m_pInfo->m_pJsPlatform && m_pInfo->m_pJsPlatform->Doc_gotoPage)
                 {
                         m_pInfo->m_pJsPlatform->Doc_gotoPage(m_pInfo->m_pJsPlatform, nPageNum);
                 }
         }
 
-        virtual FPDF_PAGE       FFI_GetPage(FPDF_DOCUMENT document,int nPageIndex)
+        FPDF_PAGE       FFI_GetPage(FPDF_DOCUMENT document,int nPageIndex)
         {
                 if(m_pInfo && m_pInfo->FFI_GetPage)
                 {
                         return m_pInfo->FFI_GetPage(m_pInfo, document, nPageIndex);
                 }
                 return NULL;
         }
 
-        virtual FPDF_PAGE FFI_GetCurrentPage(FPDF_DOCUMENT document)
+        FPDF_PAGE FFI_GetCurrentPage(FPDF_DOCUMENT document)
         {
                 if(m_pInfo && m_pInfo->FFI_GetCurrentPage)
                 {
                         return m_pInfo->FFI_GetCurrentPage(m_pInfo, document);
                 }
                 return NULL;
         }
 
         int     FFI_GetRotation(FPDF_PAGE page)
         {
@@ skipping 143 matching lines @@
         CFX_MapPtrTemplate<CPDF_Page*, CPDFSDK_PageView*> m_pageMap;
         CPDF_Document*                  m_pDoc;
 
         CPDFSDK_InterForm*              m_pInterForm;
         CPDFSDK_Annot*                  m_pFocusAnnot;
         CPDFDoc_Environment *   m_pEnv;
         CPDF_OCContext *                m_pOccontent;
         FX_BOOL                                 m_bChangeMask;
 };
 
-class CPDFSDK_PageView
+class CPDFSDK_PageView FX_FINAL
 {
 public:
         CPDFSDK_PageView(CPDFSDK_Document* pSDKDoc,CPDF_Page* page);
         ~CPDFSDK_PageView();
 public:
-        virtual void PageView_OnDraw(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,CPDF_RenderOptions* pOptions) ;
+        void PageView_OnDraw(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,CPDF_RenderOptions* pOptions) ;
 public:
         CPDF_Annot*                                             GetPDFAnnotAtPoint(FX_FLOAT pageX, FX_FLOAT pageY);
         CPDFSDK_Annot*                                  GetFXAnnotAtPoint(FX_FLOAT pageX, FX_FLOAT pageY);
         CPDF_Annot*                                             GetPDFWidgetAtPoint(FX_FLOAT pageX, FX_FLOAT pageY);
         CPDFSDK_Annot*                                  GetFXWidgetAtPoint(FX_FLOAT pageX, FX_FLOAT pageY);
         CPDFSDK_Annot*                                  GetFocusAnnot() ;
         void                                                    SetFocusAnnot(CPDFSDK_Annot* pSDKAnnot,FX_UINT nFlag = 0) {m_pSDKDoc->SetFocusAnnot(pSDKAnnot, nFlag);}
         FX_BOOL                                                 KillFocusAnnot(FX_UINT nFlag = 0) {return m_pSDKDoc->KillFocusAnnot(nFlag);}
         FX_BOOL                                                 Annot_HasAppearance(CPDF_Annot* pAnnot);
 
         CPDFSDK_Annot*                                  AddAnnot(CPDF_Dictionary * pDict);
         CPDFSDK_Annot*                                  AddAnnot(FX_LPCSTR lpSubType,CPDF_Dictionary * pDict);
         CPDFSDK_Annot*                                  AddAnnot(CPDF_Annot * pPDFAnnot);
         FX_BOOL                                                 DeleteAnnot(CPDFSDK_Annot* pAnnot);                                                     
         
         int                                                             CountAnnots();
         CPDFSDK_Annot*                                  GetAnnot(int nIndex);
         CPDFSDK_Annot*                              GetAnnotByDict(CPDF_Dictionary * pDict);
         CPDF_Page*                                              GetPDFPage(){return m_page;}
         CPDF_Document*                                  GetPDFDocument();
         CPDFSDK_Document*                               GetSDKDocument() {return m_pSDKDoc;}    
 public:
-        virtual FX_BOOL                                 OnLButtonDown(const CPDF_Point & point, FX_UINT nFlag);
-        virtual FX_BOOL                                 OnLButtonUp(const CPDF_Point & point, FX_UINT nFlag);
-        virtual FX_BOOL                                 OnChar(int nChar, FX_UINT nFlag);
-        virtual FX_BOOL                                 OnKeyDown(int nKeyCode, int nFlag);
-        virtual FX_BOOL                                 OnKeyUp(int nKeyCode, int nFlag);
+        FX_BOOL                                 OnLButtonDown(const CPDF_Point & point, FX_UINT nFlag);
+        FX_BOOL                                 OnLButtonUp(const CPDF_Point & point, FX_UINT nFlag);
+        FX_BOOL                                 OnChar(int nChar, FX_UINT nFlag);
+        FX_BOOL                                 OnKeyDown(int nKeyCode, int nFlag);
+        FX_BOOL                                 OnKeyUp(int nKeyCode, int nFlag);
 
-        virtual FX_BOOL                                 OnMouseMove(const CPDF_Point & point, int nFlag);
-        virtual FX_BOOL                                 OnMouseWheel(double deltaX, double deltaY,const CPDF_Point& point, int nFlag);
-        virtual FX_BOOL                                 IsValidAnnot(FX_LPVOID p);
+        FX_BOOL                                 OnMouseMove(const CPDF_Point & point, int nFlag);
+        FX_BOOL                                 OnMouseWheel(double deltaX, double deltaY,const CPDF_Point& point, int nFlag);
+        FX_BOOL                                 IsValidAnnot(FX_LPVOID p);
 public:
-        virtual void                                    GetCurrentMatrix(CPDF_Matrix& matrix) {matrix = m_curMatrix;}
-        virtual void                                    UpdateRects(CFX_RectArray& rects);
+        void                                    GetCurrentMatrix(CPDF_Matrix& matrix) {matrix = m_curMatrix;}
+        void                                    UpdateRects(CFX_RectArray& rects);
         void                                                    UpdateView(CPDFSDK_Annot* pAnnot);
         CFX_PtrArray*                                   GetAnnotList(){ return &m_fxAnnotArray; }
 
 public:
-        virtual int                                             GetPageIndex();
+        int                                             GetPageIndex();
         void                                                    LoadFXAnnots();
 private:
         CPDF_Matrix m_curMatrix;
 
 private:
         void PageView_OnHighlightFormFields(CFX_RenderDevice* pDevice, CPDFSDK_Widget* pWidget);
 
 private:
         CPDF_Page* m_page;
         CPDF_AnnotList* m_pAnnotList;
@@ skipping 91 matching lines @@
                 }
                 
                 if (nStartPos < m) QuickSort(nStartPos, m, bAscend, pCompare);
                 if (nStopPos > m) QuickSort(m, nStopPos, bAscend, pCompare);
         }
 };
 
 
 #endif //_FPDFSDK_MGR_H