fpdfsdk/src/fpdfeditpage.cpp - Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/src/fpdfeditpage.cpp

Issue 370853002: pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « fpdfsdk/src/fpdf_sysfontinfo.cpp ('k') | fpdfsdk/src/fpdfsave.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 // #include "x:/pdf/fpdfapi5/include/fpdfapi.h"	7 // #include "x:/pdf/fpdfapi5/include/fpdfapi.h"

8 #include "../include/fsdk_define.h"	8 #include "../include/fsdk_define.h"

9 #include "../include/fpdfedit.h"	9 #include "../include/fpdfedit.h"

10	10

(...skipping 309 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
320 CPDF_Page* pPage = (CPDF_Page*)page;	320 CPDF_Page* pPage = (CPDF_Page*)page;

321 if (!pPage \|\| !pPage->m_pFormDict \|\| !pPage->m_pFormDict->KeyExist("Type ") \|\| !pPage->m_pFormDict->GetElement("Type")->GetDirect()	321 if (!pPage \|\| !pPage->m_pFormDict \|\| !pPage->m_pFormDict->KeyExist("Type ") \|\| !pPage->m_pFormDict->GetElement("Type")->GetDirect()

322 \|\| pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetStrin g().Compare("Page"))	322 \|\| pPage->m_pFormDict->GetElement("Type")->GetDirect()->GetStrin g().Compare("Page"))

323 {	323 {

324 return;	324 return;

325 }	325 }

326 CPDF_Dictionary* pDict = pPage->m_pFormDict;	326 CPDF_Dictionary* pDict = pPage->m_pFormDict;

327 rotate %=4;	327 rotate %=4;

328	328

329 pDict->SetAt("Rotate", FX_NEW CPDF_Number(rotate * 90));	329 pDict->SetAt("Rotate", FX_NEW CPDF_Number(rotate * 90));

330 }	330 }
	Nico 2014/07/05 03:29:13 (Also fix a -Wnewline warning while here.) (Also fix a -Wnewline warning while here.)
OLD	NEW