LayoutTests/touchadjustment/simple-shadow-dom.html - Issue 370843002: Allow touch adjustment to return Shadow DOM node.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/touchadjustment/simple-shadow-dom.html

Issue 370843002: Allow touch adjustment to return Shadow DOM node. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add simple shadow dom test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/touchadjustment/resources/touchadjustment.js ('K') | « LayoutTests/touchadjustment/resources/touchadjustment.js ('k') | LayoutTests/touchadjustment/simple-shadow-dom-expected.txt » ('j') | Source/core/page/EventHandler.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	Rick Byers 2014/07/07 18:25:44 nit: for new tests we generally avoid adding any u nit: for new tests we generally avoid adding any unnecessary tags. You should be able to omit the html and body tags. Zeeshan Qureshi 2014/07/09 16:10:15 Oh I thought you needed the tags if you added <hea Show quoted text On 2014/07/07 18:25:44, Rick Byers wrote: > nit: for new tests we generally avoid adding any unnecessary tags. You should > be able to omit the html and body tags. Oh I thought you needed the tags if you added <head>, removed now.
	4 <style>

	5 #targetDiv {

	6 background: #00f;

	7 height: 100px;

	8 width: 100px;

	9 position: absolute;

	10 left: 0px;

	11 top: 0px;

	12 }

	13 </style>

	14 </head>

	15 <body>

	16 <div id="targetDiv"></div>

	17

	18 <script src="../resources/js-test.js"></script>

	19 <script src="resources/touchadjustment.js"></script>

	20 <script>

	21 function addShadowDOM() {

	22 var targetDiv = document.getElementById("targetDiv");

	23 var root = targetDiv.createShadowRoot();

	24 var shadowDiv = document.createElement("div");

	25 shadowDiv.style.width = "50px";

	26 shadowDiv.style.height = "50px";

	27 shadowDiv.style.background = "#ff0";

	28 shadowDiv.style.position = "absolute";

	29 shadowDiv.style.left = "0px";

	30 shadowDiv.style.top = "0px";

	31 shadowDiv.id = 'shadowDiv';

	32 shadowDiv.addEventListener('click', function() {}, false);

	33 root.appendChild(shadowDiv);

	34 return shadowDiv;

	35 }

	36

	37 function runTouchTests() {

	38 var shadowDiv = addShadowDOM();

	39 element = document.getElementById("targetDiv");

	40 element.addEventListener('click', function() {}, false);
	Rick Byers 2014/07/07 18:25:44 what are these two handlers for? Are you just try what are these two handlers for? Are you just trying to make sure the element and document are also candidates for touch adjustment? Zeeshan Qureshi 2014/07/09 16:10:14 Yes, I borrowed this from the existing shadow dom Show quoted text On 2014/07/07 18:25:44, Rick Byers wrote: > what are these two handlers for? Are you just trying to make sure the element > and document are also candidates for touch adjustment? Yes, I borrowed this from the existing shadow dom tests but I'm pretty sure that's the purpose.
	41 document.addEventListener('click', function() {}, false);

	42 testTouchPoint(touchPoint(25, 25, 10), shadowDiv, /* allowTextNodes / false , / allowShadowDOM */ true);

	43 }

	44

	45 function runTests()

	46 {

	47 if (window.testRunner && window.internals && internals.touchNodeAdjustedToBe stClickableNode) {

	48 description('Test that a hit right in the middle of a shadow dom node re turns it and not its host.')

	49 runTouchTests();

	50 }

	51 }

	52 runTests();

	53 </script>

	54 </body>

	55 </html>

OLD	NEW