Move resource_type.* from webkit/ to content/.

Move resource_type.* from webkit/ to content/.

Put it in content namespace while doing this.

BUG=338338
TEST=None
TBR=jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281469

[tfarina, 2014-07-04 23:34:29]

TBRing...

[tfarina, 2014-07-04 23:34:31]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-04 23:35:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/370833002/1

[tfarina, 2014-07-04 23:49:46]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-04 23:50:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/370833002/40001

[commit-bot: I haz the power, 2014-07-05 03:13:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-07-05 03:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-05 03:25:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[tfarina, 2014-07-05 15:25:46]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-07-05 15:26:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/370833002/60001

[commit-bot: I haz the power, 2014-07-05 19:10:14]

Change committed as 281469

[jam, 2014-07-14 15:16:31]

thanks for doing this, some comments as the content api is stricter than
src/webkit

https://codereview.chromium.org/370833002/diff/60001/content/public/common/re...
File content/public/common/resource_type.h (right):

https://codereview.chromium.org/370833002/diff/60001/content/public/common/re...
content/public/common/resource_type.h:19: MAIN_FRAME = 0,  // top level page
now that this is in content/public, it should conform to the Content API's
guidelines for enums (see
http://www.chromium.org/developers/content-module/content-api).

i.e. this should be 

enum ResourceType {
  RESOURCE_TYPE_MAIN_FRAME = 0,  //...
  RESOURCE_TYPE_SUB_FRAME,  // ...
  RESOURCE_TYPE_STYLESHEET,  // ...
.
.
.
};

For the methods below, they should be moved out:
-FromTargetType is only called from within content (child & renderer), so it
should be moved to content/child/target_type_conversion.h/cc (or similar, just a
proposed file name)
-ValidType/FromInt/IsSubresource aren't called from anywhere so they can be
removed
-IsSharedWorker/IsServiceWorker are not necessary, they're just an enum
comparison and are only called in 5 places. so remove them and just have the
source code do the if check
-IsFrame is called in a number of places, so probably best to leave it in this
header as a function. since it's not scoped in a class anymore, it would need a
more descriptive name. something like
bool IsResourceTypeFrame(ResourceType resource_type);

[tfarina, 2014-07-27 23:50:02]

https://codereview.chromium.org/370833002/diff/60001/content/public/common/re...
File content/public/common/resource_type.h (right):

https://codereview.chromium.org/370833002/diff/60001/content/public/common/re...
content/public/common/resource_type.h:19: MAIN_FRAME = 0,  // top level page
On 2014/07/14 15:16:31, jam wrote:
> now that this is in content/public, it should conform to the Content API's
> guidelines for enums (see
> http://www.chromium.org/developers/content-module/content-api).
> 
> i.e. this should be 
> 
> enum ResourceType {
>   RESOURCE_TYPE_MAIN_FRAME = 0,  //...
>   RESOURCE_TYPE_SUB_FRAME,  // ...
>   RESOURCE_TYPE_STYLESHEET,  // ...
> .
> .
> .
> };
> 
> For the methods below, they should be moved out:
> -FromTargetType is only called from within content (child & renderer), so it
> should be moved to content/child/target_type_conversion.h/cc (or similar, just
a
> proposed file name)
> -ValidType/FromInt/IsSubresource aren't called from anywhere so they can be
> removed
> -IsSharedWorker/IsServiceWorker are not necessary, they're just an enum
> comparison and are only called in 5 places. so remove them and just have the
> source code do the if check
> -IsFrame is called in a number of places, so probably best to leave it in this
> header as a function. since it's not scoped in a class anymore, it would need
a
> more descriptive name. something like
> bool IsResourceTypeFrame(ResourceType resource_type);
Hi John,

I will be addressing this here -> https://codereview.chromium.org/425653002

Thanks for the analysis.

I didn't expect so many usages of ResourceType:: :-/

So it will take a while until I can get it all, but I will get there.