Start/Stop Cards Polling Depending on Notification Center State

Start/Stop Cards Polling Depending on Notification Center State

Added logic to monitor the state of our notification center checkbox
and to start or stop polling if the checkbox is checked or unchecked
respectively.

BUG=164227
TEST=Get the Notification Center to show up. Click on the Settings Icon (Cog). Uncheck or check the Google Now checkbox. When unchecked, server pings should stop and Chrome should stop running under background mode via the removal of the background permission. When checked, Chrome Now spins back up as long as the user is signed in.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230715

[vadimt, 2013-10-23 22:29:13]

Could you include "TEST=" in the CL description?

https://codereview.chromium.org/37083004/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/37083004/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:279: // TODO(vadimt): Figure
out what to do when notifications are
Please remove this comment.

[robliao, 2013-10-23 22:54:44]

Done

https://codereview.chromium.org/37083004/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/37083004/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:279: // TODO(vadimt): Figure
out what to do when notifications are
On 2013/10/23 22:29:14, vadimt wrote:
> Please remove this comment.

Done.

[vadimt, 2013-10-24 00:12:14]

LGTM
Please add to "TEST=" that server pings should stop, and background permission
should go away after unchecking (and vice versa), so that testers know what to
expect. Our testers happen to look at our CLs :)

[robliao, 2013-10-24 00:13:39]

Done

[commit-bot: I haz the power, 2013-10-24 00:14:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/37083004/40001

[govind, 2013-10-24 00:16:14]

Thanks, Robert & Vadim!

We will add a test case for this.


On Wed, Oct 23, 2013 at 5:14 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
> https://chromium-status.**appspot.com/cq/robliao@**
>
chromium.org/37083004/40001<https://chromium-status.appspot.com/cq/robliao@chromium.org/37083004/40001>
>
>
>
https://codereview.chromium.**org/37083004/<https://codereview.chromium.org/3...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-24 03:45:57]

List of reviewers changed. govind@google.com did a drive-by without LGTM'ing!

[vadimt, 2013-10-24 14:22:53]

On 2013/10/24 03:45:57, I haz the power (commit-bot) wrote:
> List of reviewers changed.
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=govind@google.com did a
drive-by without LGTM'ing!

I'm re-submitting it...

[commit-bot: I haz the power, 2013-10-24 14:24:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/37083004/40001

[commit-bot: I haz the power, 2013-10-24 14:28:04]

Change committed as 230715