Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 370823002: Availability of sprintf_s is a C standard library thing, not a compiler thing. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Availability of sprintf_s is a C standard library thing, not a compiler thing. Our clang/win build currently uses MSVS's C library, so it doesn't have snprintf but it does have sprintf_s. BUG=chromium:82385 LOG=n R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ostreams.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 5 months ago (2014-07-04 23:05:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-07 07:15:49 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-07 07:21:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698