chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 370813003: Move kInstallDate from chrome/common/pref_names.h to components/metrics/metrics_pref_names.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 370813003: Move kInstallDate from chrome/common/pref_names.h to components/metrics/metrics_pref_names.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review:isherman Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 1a7af6bfc78e515bd8d50e82bc8d3ad95b9ec9f0..6a2c51bbf97bdfb94b599535b29a1895a32a71bc 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -146,7 +146,6 @@ scoped_ptr<ChromeMetricsServiceClient> ChromeMetricsServiceClient::Create(

// static

void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {

- registry->RegisterInt64Pref(prefs::kInstallDate, 0);

registry->RegisterInt64Pref(prefs::kUninstallLastLaunchTimeSec, 0);

registry->RegisterInt64Pref(prefs::kUninstallLastObservedRunTimeSec, 0);

@@ -198,10 +197,6 @@ std::string ChromeMetricsServiceClient::GetVersionString() {

return version;

}

-int64 ChromeMetricsServiceClient::GetInstallDate() {

- return g_browser_process->local_state()->GetInt64(prefs::kInstallDate);

void ChromeMetricsServiceClient::OnLogUploadComplete() {

// Collect network stats after each UMA upload.

network_stats_uploader_.CollectAndReportNetworkStats();