Move kInstallDate from chrome/common/pref_names.h to components/metrics/metrics_pref_names.h

chrome/browser/metrics/chrome_metrics_service_client.cc

Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 2a180d201a10d7a12faad557617d7a1c565ecf7d..272e1719f6357756a39cb6ed8c99b85aa1fbe963 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -144,7 +144,7 @@ scoped_ptr<ChromeMetricsServiceClient> ChromeMetricsServiceClient::Create(
 
 // static
 void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {
-  registry->RegisterInt64Pref(prefs::kInstallDate, 0);
+  registry->RegisterInt64Pref(metrics::prefs::kInstallDate, 0);

[Ilya Sherman, 2014/07/08 03:26:33]

It would probably be more appropriate to move this into the metrics component as
well; likewise, the GetInstallDate() call below.

[gab, 2014/07/08 17:41:02]

Ok, that makes it such that MetricsLog::RecordEnvironment() now has to take an
|install_date| param (since it's under the MetricsService and I don't think we
want to introduce a loop just to make GetInstallDate() accessible).

But I think that's okay.. up to you.

   registry->RegisterInt64Pref(prefs::kUninstallLastLaunchTimeSec, 0);
   registry->RegisterInt64Pref(prefs::kUninstallLastObservedRunTimeSec, 0);
 
@@ -197,7 +197,8 @@ std::string ChromeMetricsServiceClient::GetVersionString() {
 }
 
 int64 ChromeMetricsServiceClient::GetInstallDate() {
-  return g_browser_process->local_state()->GetInt64(prefs::kInstallDate);
+  return g_browser_process->local_state()->GetInt64(
+      metrics::prefs::kInstallDate);
 }
 
 void ChromeMetricsServiceClient::OnLogUploadComplete() {