Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 370793003: Fix location of appcache_service.h in .gypi file. (Closed)

Created:
6 years, 5 months ago by Bernhard Bauer
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix location of appcache_service.h in .gypi file. BUG=338338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Bernhard Bauer
Please review.
6 years, 5 months ago (2014-07-04 13:50:00 UTC) #1
Bernhard Bauer
Friendly post-holiday ping?
6 years, 5 months ago (2014-07-09 09:29:19 UTC) #2
pilgrim_google
+reviewers
6 years, 5 months ago (2014-07-09 19:04:35 UTC) #3
Bernhard Bauer
Ping?
6 years, 5 months ago (2014-07-14 09:30:56 UTC) #4
jam
lgtm
6 years, 5 months ago (2014-07-15 00:36:27 UTC) #5
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-15 08:08:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/370793003/1
6 years, 5 months ago (2014-07-15 08:09:00 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 19:10:36 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 19:42:25 UTC) #9
Message was sent while issue was closed. 
Change committed as 283238

Powered by Google App Engine
This is Rietveld 408576698