Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Issue 370633002: Revert 281286 "Add gyp machinery to build with packed ARM relati..." (Closed)

Created:
6 years, 5 months ago by csharp
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 281286 "Add gyp machinery to build with packed ARM relati..." Broke Android compile: FAILED: cd ../../net; python ../build/android/gyp/pack_arm_relocations.py "--enable-packing=0" "--stripped-libraries-dir=../out/Release/gen/stripped_libraries" "--packed-libraries-dir=../out/Release/net_unittests_apk/libs/armeabi-v7a" "--libraries-file=../out/Release/net_unittests_apk/native_libraries.json" "--stamp=../out/Release/net_unittests_apk/pack_arm_relocations.stamp" Traceback (most recent call last): File "../build/android/gyp/pack_arm_relocations.py", line 108, in <module> sys.exit(main()) File "../build/android/gyp/pack_arm_relocations.py", line 99, in main CopyArmLibraryUnchanged(library_path, output_path) File "../build/android/gyp/pack_arm_relocations.py", line 58, in CopyArmLibraryUnchanged shutil.copy(library_path, output_path) File "/usr/lib/python2.7/shutil.py", line 117, in copy copyfile(src, dst) File "/usr/lib/python2.7/shutil.py", line 83, in copyfile with open(dst, 'wb') as fdst: IOError: [Errno 2] No such file or directory: u'../out/Release/net_unittests_apk/libs/armeabi-v7a/libnet_unittests.so' ninja: build stopped: subcommand failed. > Add gyp machinery to build with packed ARM relative relocations. > > Add gypi and python files to support packing ARM relative relocations > during the build process. > > Define a use_relocation_packer gyp variable to turn ARM relocation > packing on and off (currently set to 0). > > BUG=385553 > > Review URL: https://codereview.chromium.org/358863002 TBR=simonb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -224 lines) Patch
M trunk/src/build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/build/android/gyp/pack_arm_relocations.py View 1 chunk +0 lines, -108 lines 0 comments Download
D trunk/src/build/android/pack_arm_relocations.gypi View 1 chunk +0 lines, -76 lines 0 comments Download
M trunk/src/build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/build/java_apk.gypi View 7 chunks +3 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
csharp
6 years, 5 months ago (2014-07-03 18:39:38 UTC) #1
csharp
Committed patchset #1 manually as r281303 (tree was closed).
6 years, 5 months ago (2014-07-03 18:39:43 UTC) #2
simonb1
6 years, 5 months ago (2014-07-04 11:15:34 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698