Issue 370603003: Code cleanup

Issue 370603003: Code cleanup (Closed)

Created:
6 years, 5 months ago by sdefresne

Modified:
6 years, 5 months ago

Reviewers:
Miguel Garcia, blundell

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.7

Project:
chromium

Visibility:
Public.

More Reviews

Description

Code cleanup Remove reference to CancelableRequest{Consumer,Producer} from //chrome/browser/history/android and remove dead code. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285295

Patch Set 1 #

Total comments: 2

Patch Set 2 : clang-format #

Patch Set 3 : Fix unit tests #

Patch Set 4 : Rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -126 lines)			Patch
M	chrome/browser/android/provider/chrome_browser_provider.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/android/provider/chrome_browser_provider.cc	View	1 2	24 chunks	+24 lines, -82 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service.h	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service_unittest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/android/sqlite_cursor_unittest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/history_backend.h	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
D	chrome/browser/history/history_marshaling_android.h	View		1 chunk	+0 lines, -29 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

sdefresne

Could you please take a look? This is the last of a series of seven ...

6 years, 5 months ago (2014-07-03 17:21:18 UTC) #1

blundell

lgtm https://codereview.chromium.org/370603003/diff/1/chrome/browser/history/history_backend.cc File chrome/browser/history/history_backend.cc (right): https://codereview.chromium.org/370603003/diff/1/chrome/browser/history/history_backend.cc#newcode36 chrome/browser/history/history_backend.cc:36: #include "chrome/browser/history/typed_url_syncable_service.h" kill

6 years, 5 months ago (2014-07-04 10:31:12 UTC) #2

sdefresne

https://codereview.chromium.org/370603003/diff/1/chrome/browser/history/history_backend.cc File chrome/browser/history/history_backend.cc (right): https://codereview.chromium.org/370603003/diff/1/chrome/browser/history/history_backend.cc#newcode36 chrome/browser/history/history_backend.cc:36: #include "chrome/browser/history/typed_url_syncable_service.h" On 2014/07/04 10:31:12, blundell wrote: > kill ...

6 years, 5 months ago (2014-07-04 12:43:14 UTC) #4

Miguel Garcia

On 2014/07/04 12:43:14, sdefresne wrote: > https://codereview.chromium.org/370603003/diff/1/chrome/browser/history/history_backend.cc > File chrome/browser/history/history_backend.cc (right): > > https://codereview.chromium.org/370603003/diff/1/chrome/browser/history/history_backend.cc#newcode36 > ...

6 years, 5 months ago (2014-07-07 09:56:53 UTC) #5

sdefresne

miguelg: all dependent CLs have reached trunk, could you take another look?

6 years, 5 months ago (2014-07-18 16:53:16 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/370603003/80001

6 years, 5 months ago (2014-07-24 14:15:42 UTC) #10

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...

6 years, 5 months ago (2014-07-24 16:14:44 UTC) #11

Message was sent while issue was closed.

Change committed as 285295

Expand Messages | Collapse Messages