Have the Worker destructor handle non-started Workers better.

Have the Worker destructor handle non-started Workers better.

If the creation of a Worker fails early due to an invalid script URL, the
worker context proxy isn't created. Hence, the assumption that the
Worker's ExecutionContext is kept alive by it doesn't apply. Adjust
the asserting in the destructor to reflect that.

R=haraken@chromium.org
BUG=301575
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177474

[sof, 2014-07-03 12:11:23]

Please take a look.

This one trips up Oilpan tests once in a while, esp. with leak detection
enabled. e.g.,


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...

[haraken, 2014-07-03 12:14:04]

LGTM

https://codereview.chromium.org/370553003/diff/1/Source/core/workers/Worker.cpp
File Source/core/workers/Worker.cpp (right):

https://codereview.chromium.org/370553003/diff/1/Source/core/workers/Worker.c...
Source/core/workers/Worker.cpp:97: {

Add ASSERT(m_contextProxy)

https://codereview.chromium.org/370553003/diff/1/Source/core/workers/Worker.c...
Source/core/workers/Worker.cpp:131: WorkerThreadStartMode startMode =
DontPauseWorkerGlobalScopeOnStart;

Add ASSERT(m_contextProxy)

[sof, 2014-07-03 12:23:11]

Thanks.

https://codereview.chromium.org/370553003/diff/1/Source/core/workers/Worker.cpp
File Source/core/workers/Worker.cpp (right):

https://codereview.chromium.org/370553003/diff/1/Source/core/workers/Worker.c...
Source/core/workers/Worker.cpp:97: {
On 2014/07/03 12:14:04, haraken wrote:
> 
> Add ASSERT(m_contextProxy)

Done.

https://codereview.chromium.org/370553003/diff/1/Source/core/workers/Worker.c...
Source/core/workers/Worker.cpp:131: WorkerThreadStartMode startMode =
DontPauseWorkerGlobalScopeOnStart;
On 2014/07/03 12:14:03, haraken wrote:
> 
> Add ASSERT(m_contextProxy)

Why not; done.

[sof, 2014-07-03 12:24:52]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-07-03 12:25:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/370553003/40001

[commit-bot: I haz the power, 2014-07-03 13:28:43]

Change committed as 177474