Add myself to authors

Add myself to authors

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230778

[rwlbuis, 2013-10-23 20:02:49]

Add myself to AUTHORS. I did some patches in the summer, hopefully some more
today and definitely more in the future :)

[abarth-chromium, 2013-10-24 14:05:46]

On 2013/10/23 20:02:49, rwlbuis wrote:
> Add myself to AUTHORS. I did some patches in the summer, hopefully some more
> today and definitely more in the future :)

In https://chromium.googlesource.com/chromium/src:

$ git log --author=rwlbuis
$

I don't see any CLs in the main Chromium repository.  Can you link to one of
them?

[eseidel, 2013-10-24 14:12:15]

Rob has a zillion patches under older accounts in blink. But aren't you
already covered under the wider Samsung cla now?
On Oct 24, 2013 7:05 AM, <abarth@chromium.org> wrote:

> On 2013/10/23 20:02:49, rwlbuis wrote:
>
>> Add myself to AUTHORS. I did some patches in the summer, hopefully some
>> more
>> today and definitely more in the future :)
>>
>
> In
https://chromium.googlesource.**com/chromium/src<https://chromium.googlesourc...
> :
>
> $ git log --author=rwlbuis
> $
>
> I don't see any CLs in the main Chromium repository.  Can you link to one
> of
> them?
>
>
https://codereview.chromium.**org/37053005/<https://codereview.chromium.org/3...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rwlbuis, 2013-10-24 14:55:25]

On 2013/10/24 14:05:46, abarth wrote:
> On 2013/10/23 20:02:49, rwlbuis wrote:
> > Add myself to AUTHORS. I did some patches in the summer, hopefully some more
> > today and definitely more in the future :)
> 
> In https://chromium.googlesource.com/chromium/src:
> 
> $ git log --author=rwlbuis
> $
> 
> I don't see any CLs in the main Chromium repository.  Can you link to one of
> them?

To be clear I never submitted a patch for Chromium. I did three patches over the
summer on my own account rwlbuis@gmail.com, then I did one Samsung patch for
Blink this week and more will follow. Eric is right that the patches from the
past through WebKit are a lot by now :)

[lgombos, 2013-10-24 15:01:46]

On 2013/10/24 14:12:15, eseidel wrote:

> Rob has a zillion patches under older accounts in blink. But aren't you
> already covered under the wider Samsung cla now?

My understanding is that some scripts/commit bot checks the AUTHORS file and if
the patch author is not listed the patch will not be committed (perhaps this is
only at chromium side as of now).

http://www.chromium.org/developers/contributing-code suggests that "If you've
never submitted code before, you must add your (or your organization's) name and
contact info to the AUTHORS file".   As the CLA process is the same for blink
and chromium, we were assuming the same for the AUTHORS file.

[abarth-chromium, 2013-10-24 15:19:05]

You're probably right.  I'm not sure how this is supposed to work.  Maybe Eric
knows.  In any case, as long as you've signed the CLA, I don't think there's any
reason not to add yourself to this file.  At the very least, that will make it
easier for you to contribute to Chromium as well.

I leave it in Eric's hands.

[eseidel, 2013-10-24 15:20:25]

lgtm

[commit-bot: I haz the power, 2013-10-24 15:23:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/37053005/70001

[commit-bot: I haz the power, 2013-10-24 18:35:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/37053005/350001

[commit-bot: I haz the power, 2013-10-24 18:45:32]

Change committed as 230778