Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: core/scripts/make_runtime_features.py

Issue 37053003: Roll IDL to multivm@1467 (Closed) Base URL: https://dart.googlecode.com/svn/third_party/WebCore
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/scripts/make_event_factory.py ('k') | core/scripts/name_utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/scripts/make_runtime_features.py
diff --git a/core/scripts/make_runtime_features.py b/core/scripts/make_runtime_features.py
index 6ec681b7119ac825019b7ca8df76e05916cc7323..ad84a25a7dcd9a8960fccb35a8495caf3b770cae 100755
--- a/core/scripts/make_runtime_features.py
+++ b/core/scripts/make_runtime_features.py
@@ -32,6 +32,7 @@ import sys
from in_file import InFile
import in_generator
+from name_utilities import lower_first
import template_expander
@@ -47,7 +48,6 @@ class RuntimeFeatureWriter(in_generator.Writer):
'depends_on' : [],
'custom': False,
'status': None,
- 'writeable': False,
}
def __init__(self, in_file_path, enabled_conditions):
@@ -59,7 +59,7 @@ class RuntimeFeatureWriter(in_generator.Writer):
self._features = self.in_file.name_dictionaries
# Make sure the resulting dictionaries have all the keys we expect.
for feature in self._features:
- feature['first_lowered_name'] = self._lower_first(feature['name'])
+ feature['first_lowered_name'] = lower_first(feature['name'])
# Most features just check their isFooEnabled bool
# but some depend on more than one bool.
enabled_condition = "is%sEnabled" % feature['name']
@@ -68,15 +68,6 @@ class RuntimeFeatureWriter(in_generator.Writer):
feature['enabled_condition'] = enabled_condition
self._non_custom_features = filter(lambda feature: not feature['custom'], self._features)
- def _lower_first(self, string):
- lowered = string[0].lower() + string[1:]
- lowered = lowered.replace("cSS", "css")
- lowered = lowered.replace("iME", "ime")
- lowered = lowered.replace("hTML", "html")
- lowered = lowered.replace("sVG", "svg")
- lowered = lowered.replace("wOFF", "woff")
- return lowered
-
def _feature_sets(self):
# Another way to think of the status levels is as "sets of features"
# which is how we're referring to them in this generator.
« no previous file with comments | « core/scripts/make_event_factory.py ('k') | core/scripts/name_utilities.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698