Translate: Implement reset the denial state on chrome://translate-internals

chrome/browser/resources/translate_internals/translate_internals.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
   'use strict';
 
   cr.define('cr.translateInternals', function() {
 
     var detectionLogs_ = null;
@@ skipping 42 matching lines @@
         if (tabpanelIds.indexOf(id) == -1)
           return;
 
         $(id).selected = true;
       };
 
       window.onhashchange = activateTabByHash;
       activateTabByHash();
     }
 
+    /*
+     * Creates a button to dismiss an item.
+     *
+     * @param {Function} func Callback called when the button is clicked.
+     */
+    function createDismissingButton(func) {
+      var button = document.createElement('button');
+      button.textContent = 'X';
+      button.classList.add('dismissing');
+      button.addEventListener('click', function(e) {
+        e.preventDefault();
+        func();
+      }, false);
+      return button;
+    }
+
     /**
      * Creates a new LI element with a button to dismiss the item.
      *
      * @param {string} text The lable of the LI element.
      * @param {Function} func Callback called when the button is clicked.
      */
     function createLIWithDismissingButton(text, func) {
       var span = document.createElement('span');
       span.textContent = text;
 
       var li = document.createElement('li');
       li.appendChild(span);
-
-      var button = document.createElement('button');
-      button.textContent = 'X';
-      button.addEventListener('click', function(e) {
-        e.preventDefault();
-        func();
-      }, false);
-
-      li.appendChild(button);
+      li.appendChild(createDismissingButton(func));
       return li;
     }
 
     /**
      * Formats the language name to a human-readable text. For example, if
      * |langCode| is 'en', this may return 'en (English)'.
      *
      * @param {string} langCode ISO 639 language code.
      * @return {string} The formatted string.
      */
@@ skipping 105 matching lines @@
               formatLanguageCode(toLangCode);
 
           var li = createLIWithDismissingButton(text, function() {
             chrome.send('removePrefItem',
                         ['whitelists', fromLangCode, toLangCode]);
           });
           ul.appendChild(li);
         });
       }
 
-      var p = document.querySelector('#prefs-dump p');
+      var p = $('prefs-too-often-denied');
+      p.classList.toggle('prefs-setting-disabled',
+                         !detail['translate_too_often_denied']);
+      p.appendChild(createDismissingButton(function() {

[Evan Stade, 2014/07/07 16:12:39]

I think if you do:

p.appendChild(createDismissingButton(
    chrome.send.bind(null, 'removePrefItem', ['too_often_denied'])));

then we can avoid the closure created by the anonymous function

[hajimehoshi, 2014/07/08 05:33:47]

Done.

+        chrome.send('removePrefItem', ['too_often_denied']);
+      }));
+
+      p = document.querySelector('#prefs-dump p');
       var content = JSON.stringify(detail, null, 2);
       p.textContent = content;
     }
 
     /**
      * Handles the message of 'supportedLanguagesUpdated' from the browser.
      *
      * @param {Object} details the object which represents the supported
      *     languages by the Translate server.
      */
@@ skipping 211 matching lines @@
   /**
    * The entry point of the UI.
    */
   function main() {
     cr.doc.addEventListener('DOMContentLoaded',
                             cr.translateInternals.initialize);
   }
 
   main();
 })();